search

intel / ipmctl

BSD 3-Clause "New" or "Revised" License
184 stars 62 forks source link

-o nvmxml not functional #118

Closed kin-cho closed 5 years ago

kin-cho commented 5 years ago

support.txt_platform_support_info.txt

The "-o nvmxml" option to "ipmctl dump .. -support" is not functional. For example, the output of this command:

ipmctl dump -o nvmxml -destination /tmp/supportlog.xml -support

is /tmp/supportlog.xml_platform_support_info.txt, which is plain text instead of nvmxml.

I see DumpSupportCommand in DumpSupportCommand.c lacks the code to inject the OUTPUT_OPTION_NVMXML option while running the DumpPlatformLevelCmds with PrintAndExecuteCommand, if incoming command to DumpSupportCommand contains OUTPUT_OPTION_NVMXML.

Will DumpSupportCommand eventually support the "-o nvmxml" incoming option? If not, please remove this block of code below:

ifdef::os_build[] -o (text|nvmxml):: -output (text|nvmxml):: Changes the output format. One of: "text" (default) or "nvmxml". endif::os_build[]

from this file: Documentation/ipmctl/Support_and_Maintenance/ipmctl-dump-support-data.txt

ipmctl: both 01.00.00.3467 and 02.00.00.3542 Oracle Linux 4.14.35-1902.6.2.el7uek.x86_64 FW 01.02.00.5375

kellycouch commented 5 years ago

Thank you for the bug report.

gldiviney commented 5 years ago

Updated documentation - ffa27a2a3360e85da594fb330d8e7f31cefc64ff