intel / ipmctl

BSD 3-Clause "New" or "Revised" License
184 stars 62 forks source link

Don't leak private symbols. #185

Closed kilobyte closed 2 years ago

kilobyte commented 2 years ago

Only symbols that are a part of the public API (ie, nvm_management.h) should be visible.

This was already done properly on Windows (by the NVM_API define), let's switch this on Unix as well.

My immediate reason is that the symbol churn interfered with ABI breakage checks provided by Debian tooling — but there are other benefits for not polluting symbols, such as avoiding conflicts with other programs' or libraries functions with similar generic names.