search

intel / ipmctl

BSD 3-Clause "New" or "Revised" License
183 stars 62 forks source link

Isolates amd64 private functions to support compilation on non-amd64 #195

Closed fengchunsong closed 2 years ago

fengchunsong commented 2 years ago

Supports comilation on non-amd64 platforms. ARM64 can be compiled successfully with this patch.

Signed-off-by: Chunsong Feng fengchunsong@huawei.com

fengchunsong commented 2 years ago

@StevenPontsler @pawelnass please help to review this patch, DAOS on arm64 use ipmctl, this patch is to fix the compile error on https://daosio.atlassian.net/browse/DAOS-11060

StevenPontsler commented 2 years ago

We will take a look. I didn't think it would be of any use on an Arm system.

StevenPontsler commented 2 years ago

@fengchunsong -- looking at issue on DAOS it appears like the issue is resolved in that this utility is now excluded from the configuration with the problem. Is a change still needed?

I believe the patch changes the functionality of the one function. The function currently always returns the next parameter where in patch it returns the next parameter.

fengchunsong commented 2 years ago

Yes, the DAOS dependency has been removed, this patch is not needed, thank you.