intel / ipu6-drivers

GNU General Public License v2.0
160 stars 51 forks source link

Fails to build against 6.3 #140

Open mweinelt opened 1 year ago

mweinelt commented 1 year ago
ipu6-drivers>   CC [M]  /build/source/drivers/media/pci/intel/ipu6/../ipu-psys-compat32.o
ipu6-drivers>   LD [M]  /build/source/intel_vsc.o
ipu6-drivers>   LD [M]  /build/source/mei_ace.o
ipu6-drivers>   LD [M]  /build/source/mei_csi.o
ipu6-drivers>   LD [M]  /build/source/i2c-ljca.o
ipu6-drivers>   LD [M]  /build/source/gpio-ljca.o
ipu6-drivers>   LD [M]  /build/source/mei_ace_debug.o
ipu6-drivers>   LD [M]  /build/source/mei_pse.o
ipu6-drivers>   LD [M]  /build/source/spi-ljca.o
ipu6-drivers> /build/source/drivers/media/pci/intel/ipu6/../ipu-isys-csi2.c:473:1: warning: 'csi2_try_fmt' defined but not used [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wunused-function-Wunused-function8;;]
ipu6-drivers>   473 | csi2_try_fmt(struct ipu_isys_video *av,
ipu6-drivers>       | ^~~~~~~~~~~~
ipu6-drivers> /build/source/drivers/media/pci/intel/ipu6/../cio2-bridge.c: In function 'cio2_bridge_unregister_sensors':
ipu6-drivers> /build/source/drivers/media/pci/intel/ipu6/../cio2-bridge.c:296:17: error: implicit declaration of function 'software_node_unregister_nodes'; did you mean 'software_node_unregister'? [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-function-declaration-Werror=implicit-function-declaration8;;]
ipu6-drivers>   296 |                 software_node_unregister_nodes(sensor->swnodes);
ipu6-drivers>       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ipu6-drivers>       |                 software_node_unregister
ipu6-drivers> /build/source/drivers/media/pci/intel/ipu6/../cio2-bridge.c: In function 'cio2_bridge_connect_sensor':
ipu6-drivers> /build/source/drivers/media/pci/intel/ipu6/../cio2-bridge.c:355:23: error: implicit declaration of function 'software_node_register_nodes'; did you mean 'software_node_register'? [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-function-declaration-Werror=implicit-function-declaration8;;]
ipu6-drivers>   355 |                 ret = software_node_register_nodes(sensor->swnodes);
ipu6-drivers>       |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
ipu6-drivers>       |                       software_node_register
ipu6-drivers>   LD [M]  /build/source/ljca.o
ipu6-drivers> cc1: some warnings being treated as errors
ipu6-drivers> make[4]: *** [/nix/store/jzhmim38g62p5ji45fnmm7vk45in5nig-linux-6.3.1-dev/lib/modules/6.3.1/source/scripts/Makefile.build:252: /build/source/drivers/media/pci/intel/ipu6/../cio2-bridge.o] Error 1
ipu6-drivers> make[4]: *** Waiting for unfinished jobs....
ipu6-drivers>   LD [M]  /build/source/mei-vsc.o
ipu6-drivers> make[3]: *** [/nix/store/jzhmim38g62p5ji45fnmm7vk45in5nig-linux-6.3.1-dev/lib/modules/6.3.1/source/scripts/Makefile.build:494: /build/source/drivers/media/pci/intel/ipu6] Error 2
ipu6-drivers> make[2]: *** [/nix/store/jzhmim38g62p5ji45fnmm7vk45in5nig-linux-6.3.1-dev/lib/modules/6.3.1/source/scripts/Makefile.build:494: /build/source/drivers/media/pci/intel] Error 2
ipu6-drivers> make[1]: *** [/nix/store/jzhmim38g62p5ji45fnmm7vk45in5nig-linux-6.3.1-dev/lib/modules/6.3.1/source/Makefile:2025: /build/source] Error 2
ipu6-drivers> make: *** [Makefile:71: all] Error 2

Affected by

commit 3dbdd92014a410778de8406e9e3253e353f51c2b
Author: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date:   Wed Dec 28 11:49:22 2022 +0200

    software node: Remove unused APIs

    There are no more users of software_node_register_nodes() and
    software_node_unregister_nodes(). Remove them.

    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
    Tested-by: Daniel Scally <dan.scally@ideasonboard.com>
    Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
    Link: https://lore.kernel.org/r/20221228094922.84119-5-andriy.shevchenko@linux.intel.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
androw commented 1 year ago

Fixed in https://github.com/intel/ipu6-drivers/commit/721a2e2d1b93b13395a6c1fc6707574ec600f0f7