search

intel / ipu6-drivers

152 stars 50 forks source link

media: ov2740: Fix "clk already disabled" / "already unprepared" oops / backtraces #179

Closed jwrdegoede closed 9 months ago

jwrdegoede commented 10 months ago

On probe() the ov2740 code was manually setting the reset GPIO instead of using the power_on() helper function.

This path however left out enabling the clk, which power_on() does do, so when power_off() runs after the probe() is done (on runtime suspend) then there are 2 ugly backtraces triggered by WARN()s in the clk-core. One for "clk already disabled" followed by one for "clk already unprepared".

Fix this by using the power_on() helper in probe().

jwrdegoede commented 9 months ago

New push:

  1. Rebased on latest master
  2. Typo fix in commitmsg: 's/ov7240/ov2740/'
hao-yao commented 9 months ago

Thank you @jwrdegoede . I also changed this part recently to prepare sending changes together with upstreamed IPU6 driver. The settings for CJFLE23 is actually 180MHz link frequency and seems Thinkpad X1 can't run the 360MHz setting.