search

intel / ipu6-drivers

152 stars 49 forks source link

media: i2c: skip hwcfg checking for Dell Non-CVF platforms #244

Closed vicamo closed 2 weeks ago

vicamo commented 2 weeks ago

Closes: #235

drhooray commented 2 weeks ago

Thanks for the patch, vicamo.

Because there is a solution to fix the issue with the following changes:

Ignore bad graph port nodes on Dell XPS 9315 ACPI: utils: Make acpi_handle_path() not static ACPI: property: Ignore bad data nodes

Plus, to add Dell device into the list as below: https://kernel.googlesource.com/pub/scm/linux/kernel/git/torvalds/linux.git/+/refs/tags/v6.9/drivers/acpi/mipi-disco-img.c#728

Is that ok for you?

btw, @hao-yao

Since this PR has been validated on the vicamo's side. If we decide to use this solution, we will also need to run tests for it.

vicamo commented 2 weeks ago

Thanks for the patch, vicamo.

Because there is a solution to fix the issue with the following changes:

Ignore bad graph port nodes on Dell XPS 9315 ACPI: utils: Make acpi_handle_path() not static ACPI: property: Ignore bad data nodes

Plus, to add Dell device into the list as below: https://kernel.googlesource.com/pub/scm/linux/kernel/git/torvalds/linux.git/+/refs/tags/v6.9/drivers/acpi/mipi-disco-img.c#728

Is that ok for you?

btw, @hao-yao

Since this PR has been validated on the vicamo's side. If we decide to use this solution, we will also need to run tests for it.

There are a few concerns. One, the fixes you mentioned are to be backported into kernel tree, and while we're running dkms across a few number of kernels, that means it will take multiple submits instead of just one. And while the hwcfg check is in the ipu6-drivers dkms, the affected kernels list may be even longer than officially planed ones. However, we always prefer upstreamed patches over sauced ones, that's something I don't have solid answer by this moment, at least not before verified on Dell 9315. You should commit at your best fit.

jwrdegoede commented 2 weeks ago

Note that this is also fixed by the combination of:

Or when using the downstream cio2-bridge.c instead of the upstream ipu-bridge.c :

jwrdegoede commented 2 weeks ago

Also note that: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/acpi?id=c7be64355fccfe7d4727681e32fce07113e40af1

fixes this for all Dell models, not just the XPS 13 9515, e.g. the XPS 13 9520 and the Latitude 9420 are also affected by having incomplete device-properties for the sensors in their ACPI tables.

And this has a Fixes tag for the commit introducing this problem so it should get backported to the affected 6.8.y and 6.9.y series.

vicamo commented 2 weeks ago

Note that this is also fixed by the combination of:

Or when using the downstream cio2-bridge.c instead of the upstream ipu-bridge.c :

Verified these on Dell Latitude 9420. Thank you.

While we need to keep 6.5 kernel running for a while, Ubuntu will still include this work-around for 6.5 builds. For 6.8 and on, the aforementioned fixes are used instead. I'm closing this with the assumption that people should also prefer upstreamed fixes.