search

intel / ipu6-drivers

GNU General Public License v2.0
163 stars 51 forks source link

Add two sensors gc5035 and s5k3l6 for ADL-M. #95

Open liang1wang opened 1 year ago

liang1wang commented 1 year ago

Both drivers are based on online, but update to support x86 and add gpio pins support. Integrate IPU6 driver to support the new sensors. The original gc5035 is from the link: https://patchwork.kernel.org/project/linux-media/patch/20200902224813.14283-4-tfiga@chromium.org The original s5k3l6 is from github-kernel_fruitPi_5.10.

With the patches, i2cdetected: :~$ sudo i2cdetect -r -y 3 0 1 2 3 4 5 6 7 8 9 a b c d e f 00: -- -- -- -- UU -- -- --//vcm 10: UU -- -- -- -- -- -- -- -- -- -- -- -- -- -- --//s5k3l6 20: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- 30: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- 40: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- 50: UU -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- //nvm 60: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- 70: -- -- -- -- -- -- -- --

:~$ sudo i2cdetect -r -y 2 0 1 2 3 4 5 6 7 8 9 a b c d e f 00: -- -- -- -- -- -- -- -- 10: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- 20: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- 30: -- -- -- -- -- -- -- UU -- -- -- -- -- -- -- -- //gc5035 40: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- 50: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- 60: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- 70: -- -- -- -- -- -- -- --

Regarding to kernel update, don't forget to add the new sensors support in .config, Kconfig and Makefile.

jwrdegoede commented 1 year ago

Interesting, thank you for your work on this.

I'm looking into making a Jasperlake device with a GC5035 sensor work. Some questions:

  1. Have you tested the full IPU6 stack (so up to the icamersrc gstreamer element) with a GC5035 sensor ?
  2. Where any changes to other projects like ipu6-camera-bins or ipu6-camera-hal necessary ?
liang1wang commented 1 year ago
  1. Yes, the sensor - gc5035 was tested by a gstreamer pipeline with IPU6 modules support.
  2. only the change in ipu6-camera-hal - https://github.com/intel/ipu6-camera-hal/pull/49 BTW, this patch was replaced by pr: https://github.com/intel/ipu6-drivers/pull/109
jwrdegoede commented 1 year ago

  1. Yes, the sensor - gc5035 was tested by a gstreamer pipeline with IPU6 modules support.

  2. only the change in ipu6-camera-hal - To support new sensor-gc5035. ipu6-camera-hal#49

That is great, thank you for the quick answer. I'll try and see if I can get this to work on Jasper Lake (once I have received the hw to test this on).