search

intel / isa-l

Intelligent Storage Acceleration Library
Other
946 stars 300 forks source link

ARM OSX build fails #276

Closed rhpvorderman closed 6 months ago

rhpvorderman commented 8 months ago

I ran into this. I found: https://github.com/intel/isa-l/pull/226 is supposed to fix this. 

  CPPAS    crc/aarch64/crc16_t10dif_pmull.lo
/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/crc16_t10dif_pmull-8d2f3f.s:208:9: error: unknown AArch64 fixup kind!
        ldr q_fold_const, fold_constant
        ^

Just making this issue in order to track the problem. I have very little skin in the game. Currently osx-arm64 are advised to use rosetta when using bioinformatics pacakges, so it is not a problem that the dependency is not natively compiled.

When it does natively compile again, I will make sure the conda-forge channel puts out a binary distribution.

cielavenir commented 6 months ago

master HEAD builds now, though it might segfault (due to using x18), avoiding in under review

cielavenir commented 6 months ago

@rhpvorderman This is now fully fixed.

rhpvorderman commented 6 months ago

Great. Looking forward to the next ISA-L release. Thanks for all that work @cielavenir !

cielavenir commented 6 months ago

oh @rhpvorderman please test if isa-l HEAD works as expected....

cielavenir commented 6 months ago

well, passed. https://github.com/cielavenir/python-isal-py2/actions/runs/8464068215

rhpvorderman commented 6 months ago

Thanks!

corneliusroemer commented 5 months ago

Very cool! Looking forward to release!