intel / isa-l_crypto

Other
271 stars 80 forks source link

rolling_hash: Implement rolling_hash2 for aarch64 #50

Closed yuhaoth closed 4 years ago

yuhaoth commented 4 years ago

Change-Id: I1b57b18a7e5d0f7365c0550086e75802f065238f Signed-off-by: Jerry Yu jerry.h.yu@arm.com

yuhaoth commented 4 years ago

@gbtucker please review

yuhaoth commented 4 years ago

@gbtucker , just update it , please review

gbtucker commented 4 years ago

Is it possible that you pushed this update to the wrong PR? The new update to this has title "sm3_mb:Add sm3_mb_test"

yuhaoth commented 4 years ago

oops, I do wrong operation.

gbtucker commented 4 years ago

@yuhaoth, does this pass the CI tests? I get a lot of 'dangerous relocation' errors when trying to cross-compile. Also some commented code in the _dispatcher.c.

yuhaoth commented 4 years ago

@yuhaoth, does this pass the CI tests? I get a lot of 'dangerous relocation' errors when trying to cross-compile. Also some commented code in the _dispatcher.c.

Yes,It pass CI tests . Could you share build log and compiler information?

gbtucker commented 4 years ago

As I looked into the error I see that the issue was on my end. Sorry, I'll schedule for integration.