intel / isa-l_crypto

Other
275 stars 80 forks source link

Add stream api std tests #61

Closed yuhaoth closed 3 years ago

yuhaoth commented 3 years ago

That‘s a share of my debug code.

To debug stream api with random test is difficult for developer. I set some cases to improve std test coverage. That might reduce developer's loading.

Those test case will trigger partial block routines.

yuhaoth commented 3 years ago

@gbtucker please review .

gbtucker commented 3 years ago

Thanks for adding to the test cases. This is great but it currently breaks when the compile option NT_LDST is set. If you can see the test aes/gcm_std_vectors_random_test.c has options for limiting alignment when this is turned on for random tests. I'm not sure how to limit for the std tests when the updates are so small.

yuhaoth commented 3 years ago

oops, I will check that.

yuhaoth commented 3 years ago

There are aes_gcm*_nt functions , Is NT_LDST still needed? If defined , the behavior is same with _nt functions.

And in aes/gcm_std_vectors_random_test.c , the update length always be multiple of 64 . Is it also a restriction ?

gbtucker commented 3 years ago

That is a correct restriction. Perhaps just add for now.

#if !defined(NT_LD) && !defined(NT_ST) && !defined(NT_LDST)
        errors += test_gcm_std_strm_vectors();
#endif
yuhaoth commented 3 years ago

Got it , the update is in internal review

yuhaoth commented 3 years ago

@gbtucker , just update it . Please review

gbtucker commented 3 years ago

Looks good, I'll schedule for integration.

gbtucker commented 3 years ago

Integrated