Closed bkucman closed 4 months ago
We are ok with some of those checkpatch errors- please list them in pull and say why we should ignore them. Please fix other errors like trailing whitespaces :)
@mtkaczyk
We are ok with "WARNING:SPLIT_STRING: quoted string split across lines", can be omitted in the review.
Chackpatch errors WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
and ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s) :
may be omitted because I plan to squash this PR
@mtkaczyk
- trailing whitespaces fixed in commit Checkpatch fixes. 7280d5c
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 16) #790: FILE: src/ledctl/ledctl.c:1089:
- fixed in commit Checkpatch fixes. 7280d5c
Ok but I have no chance to quick check if it is really done so I would recommend you to squash "checkpatch fixes" with first commit to remove not wanted warning messages.
@mtkaczyk The changes after review are merged to one commit.