intel / ledmon

Enclosure LED Utilities
GNU General Public License v2.0
72 stars 44 forks source link

Ledctl help refactor. #192

Closed bkucman closed 4 months ago

bkucman commented 6 months ago
mtkaczyk commented 6 months ago

We are ok with some of those checkpatch errors- please list them in pull and say why we should ignore them. Please fix other errors like trailing whitespaces :)

bkucman commented 6 months ago

@mtkaczyk

We are ok with "WARNING:SPLIT_STRING: quoted string split across lines", can be omitted in the review.

Chackpatch errors WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one and ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s) :may be omitted because I plan to squash this PR

mtkaczyk commented 6 months ago

@mtkaczyk

Ok but I have no chance to quick check if it is really done so I would recommend you to squash "checkpatch fixes" with first commit to remove not wanted warning messages.

bkucman commented 6 months ago

@mtkaczyk The changes after review are merged to one commit.