search

intel / ledmon

Enclosure LED Utilities
GNU General Public License v2.0
72 stars 49 forks source link

build fixes #215

Closed kloczek closed 8 months ago

kloczek commented 8 months ago

Fixes #214

kloczek commented 8 months ago

I've added more fixes to this PR to be able build 1.0.0.

ktanska commented 8 months ago

@kloczek please look at CI results, now builds are failed on our side. What complier are you using to build ledmon?

kloczek commented 8 months ago

gcc 14.x. Even publicity available basename(3) man page https://man7.org/linux/man-pages/man3/basename.3.html shows which one header files needs to be included so it has nothing to do with compiler.

PR is not finished however first two patches you can cherry pick.

mtkaczyk commented 8 months ago

PR is not finished however first two patches you can cherry pick.

No, we can't. Please submit those two patches separately because I have to see passed actions before we will start reviewing them.

kloczek commented 8 months ago

OK I;m closing this PR. If you don't see any issues with 1.0.0 I'm no longer going to waste time.

mtkaczyk commented 8 months ago

@kloczek There are processes we have to follow and one of the most important points is to have passed CI testing. This PR is failed, but you said that we can take first two patches directly- we cannot because I have no confidence that they are working.

image

That why I asked for new PR with 2 first patches because we need prove that they are working.

I didn't say that there are no issues.

kloczek commented 8 months ago

I've not deleted my fort yet. Feel free to test whatever you want.