search

intel / ledmon

Enclosure LED Utilities
GNU General Public License v2.0
73 stars 47 forks source link

Introduce nitpicker gh action #217

Closed mku514k closed 5 months ago

mku514k commented 6 months ago

Add nitpicker github action to notify codeowners when files under their ownership are modified in PR.

mku514k commented 6 months ago

Hi @tasleson @nfont @prabhakar @prabhakarpujeri, we are introducing Nitpicker github action to ledmon. It's task is to tag codeowners at PR open.

I associated some files with your github IDs, please take a look at nitpicks.yml and let me know if you're fine with this.

peluse commented 6 months ago

So I have a dumb question as I'm spinning up on the details of GHA... what's the first file for?

mku514k commented 6 months ago

So I have a dumb question as I'm spinning up on the details of GHA... what's the first file for?

Nitpicker is an action that post comments as bot under PR if certain files were modified. nitpicks.yml is used for comment-path association. More can be learned here.

This is our workaround for gh organization policy as we can't add reviewers from outside of the organization.

peluse commented 6 months ago

Great, thanks!!! I hadn't seen this one before :)

mku514k commented 5 months ago

Ping @tasleson @nfont

tasleson commented 5 months ago

@mku514k I'm OK with this, thanks!

nfont commented 5 months ago

I'm good with this.