Closed ffontaine closed 6 months ago
Hey @ffontaine, beside the checkpatch issue you have to fix, that is interesting that I recently merged your patch in mdadm: https://lore.kernel.org/linux-raid/20240508122939.000067c2@linux.intel.com/T/#t
I'm not well familiar with buildroot, I just read it is a tool for creating embedded linux images and here is a question: Are you integrating VROC with buildroot? If yes, may I ask why? I'm not against it, I'm just curious.
Thanks!
Hi,
I updated PR as requested. Concerning VROC, nope I'm not integrating it to buildroot. I'm just fixing build failures raised by buildroot autobuilders.
@tasleson, that was reverted by your patch, is it accident or you had the reason to change this?
@tasleson, that was reverted by your patch, is it accident or you had the reason to change this?
I must have ran into something which caused me to change it, but I don't remember why right now. If we run into whatever that is again, we'll deal with it then.
Replace
on_exit
byatexit
to avoid the following musl build failure raised since https://github.com/intel/ledmon/commit/bcb90426a156fcb3147b5722ed78ac8cf26f2976 which partially reverted https://github.com/intel/ledmon/commit/f08dd2c7b978233f5074aa7991fa894270934391:Fixes: