search

intel / libyami-utils

Libyami Utilities
Apache License 2.0
24 stars 45 forks source link

add built in md5 sum calculator. #123

Closed xuguangxin closed 6 years ago

xuguangxin commented 6 years ago

Android does not have libbsd. so we need use built-in md5 calculator.

uartie commented 6 years ago

Perhaps we should add option --with-md5=[libbsd|builtin] or --enable-md5=[libbsd|builtin]. This way we can still have configure fail if user requests bsd solution but forgets to install the dependency.

xuguangxin commented 6 years ago

@uartie , thanks, this is a very reasonable suggestion. I will change it

xuguangxin commented 6 years ago

@uartie , done, thanks

xuguangxin commented 6 years ago

@uartie , thanks for your careful review. done. the basic idea behind this change does not let the user choose too many things. we automatically detect libbsd. If we do not have libbsd we will choose built-in md5 sum. Force user uses libbsd is not a friendly way. Please help review last commit, I will squash it if it's ok.

thanks

xuguangxin commented 6 years ago

@uartie , sorry for missing this. updated.