search

intel / libyami-utils

Libyami Utilities
Apache License 2.0
24 stars 45 forks source link

yamitranscode: add an option to support h264 simulcast #59

Closed lizhong1008 closed 7 years ago

lizhong1008 commented 7 years ago

This patch is to support h264 simulcast encoding, which means independent bitstreams with different priority. It require to set priority_id and prefix nal unit for each bitstream.

This patch is relative to https://github.com/01org/libyami/pull/659

lizhong1008 commented 7 years ago

@chivakker "Do you have plans to enable this on yamiencode as well?", No, we mainly use yamitranscode to do encode, yamiencode will be discarded as Guangxin’s long term plan.

lizhong1008 commented 7 years ago

That means all yamiencode options should also be supported in yamitranscode, but yamitranscode options no need to be supported in yamiencode. @YuJiankang , maybe we can add enableVDEnc in yamitranscode.

xuguangxin commented 7 years ago

@lizhong1008 @YuJiankang @chivakker @wang-fei , seems yamiencode introduce some confuse, since yamitranscode can support all formats yamiencode supported . Moreover, its performance is better than yamiencode. Do you think it is ok to remove yamiencode right now?

lizhong1008 commented 7 years ago

@xuguangxin I agree to delete it but we would better have a simple application just demo how to set up encoder pipeline. Yamitranscode seems a little complex for user to learn how to set up encoder pipeline.

xuguangxin commented 7 years ago

yes, a simple encoder is in our original plan, just like https://github.com/01org/libyami-utils/blob/master/examples/simpleplayer.cpp. However, we do not have enough resource for this in near future

chivakker commented 7 years ago

I would prefer to keep yamiencode as an encoder example. I understand that it represents duplicating some work with yamitranscode but I think it is still useful in the current way.

xuguangxin commented 7 years ago

Hi @chivakker Do you think it's ok to remove it when we have simple encoder application? Do you still expect lizhong add similar command line to yamiencode?

xuguangxin commented 7 years ago

Hi @chivakker any update on this?

MicheleL-Intel commented 7 years ago

What is the current status?

uartie commented 7 years ago

Closing due to inactivity by submitter and broken builds (needs rebase). Feel free to reopen request when you address these issues.