accept size 0 byte stream in BitReader and NalReader - Githubissues

intel / libyami

Yet Another Media Infrastructure. it is core part of media codec with hardware acceleration, it is yummy to your video experience on Linux like platform.

Apache License 2.0

147 stars 106 forks source link

accept size 0 byte stream in BitReader and NalReader #752

Closed xuguangxin closed 7 years ago

xuguangxin commented 7 years ago

When we have some stream from the network, it may have 0 sizes for some chunk. We'd better support 0 sizes and report error later.

xuguangxin commented 7 years ago

@uartie , please help review this. thanks

xuguangxin commented 7 years ago

Hi @uartie . any update on this. thanks

uartie commented 7 years ago

Also, I think it might be appropriate in this case to squash these commits to avoid introducing an intermediate unit test regression commit.

xuguangxin commented 7 years ago

Thanks for the review.I will change the name

Construct_InvalidParams will check the empty/null bitstream.
Squash commits may introduce trouble when user just want cherry-pick some patch to the reversion. They usually not care about unit test. But they want changes in bit reader.

xuguangxin commented 7 years ago

@uartie done