search

intel / libyami

Yet Another Media Infrastructure. it is core part of media codec with hardware acceleration, it is yummy to your video experience on Linux like platform.
Apache License 2.0
147 stars 106 forks source link

Svc #778

Closed LindaYu17 closed 7 years ago

xuguangxin commented 7 years ago

@wudping , please help review this. Could we add some test case in daily regression to capture svct issues?

LindaYu17 commented 7 years ago

@wudping updated!

wudping commented 7 years ago

+1

xuguangxin commented 7 years ago

@wudping , is it ok to merge this?

wudping commented 7 years ago

@xuguangxin , it's okay for me.

xuguangxin commented 7 years ago

@wudping this will break yami-utils since a API change, right? could you prepare a patch for yami-utils?

wudping commented 7 years ago

@xuguangxin , okay, I am planing to add a patch for this update next week. But SVC-T regression will be latter.

wudping commented 7 years ago

hi @xuguangxin, The commit of interface modifying the typo "VideoTemproalLayers" does not impact libyami-utils.

xuguangxin commented 7 years ago

@wudping , why? this means the temporal layer never set in yami-utils?

wudping commented 7 years ago

Hi @xuguangxin , typedef struct VideoParamsCommon { uint32_t size; VAProfile profile; uint8_t level; VideoResolution resolution; VideoFrameRate frameRate; VideoTemproalLayers temporalLayers; libyami-itils sets temporalLayers via VideoParamsCommon, and yami-utils needn't to define a new variable with VideoTemproalLayers type, so we just need to modify the file VideoEncoderDefs.h in libyami.

Anyway, I am sorry for this typo. It's my fault.

xuguangxin commented 7 years ago

ok thanks for explain