intel / libyami

Yet Another Media Infrastructure. it is core part of media codec with hardware acceleration, it is yummy to your video experience on Linux like platform.
Apache License 2.0
146 stars 106 forks source link

use env var for device file to open #811

Closed jsorg71 closed 6 years ago

uartie commented 6 years ago

@jsorg71 I meant the "git commit message", not the PR title.

jsorg71 commented 6 years ago

@uartie I don't see that on other commit messages. Am I missing something? I do see them, just not on the first line.

uartie commented 6 years ago

I think you're looking at the pull-request description/titles... those are different than the actual git commits. Please reference the issue in the "git commit body". For example, see https://github.com/01org/libyami/commit/819037fdaafdef7f6234fc22b50d322755d890bf

jsorg71 commented 6 years ago

got this PR all messed up now, I made a new one #815

uartie commented 6 years ago

No problem. Github PRs can be tricky to get used to... usually you only need to rebase your source branch (i.e. avoid merge updates) and amend commits locally then force push to your upstream branch. Then PR automatically updates appropriately.