intel / libyami

Yet Another Media Infrastructure. it is core part of media codec with hardware acceleration, it is yummy to your video experience on Linux like platform.
Apache License 2.0
146 stars 106 forks source link

Makefile.am: point to build dir for generated headers #827

Closed anujm1 closed 6 years ago

anujm1 commented 6 years ago

Otherwise it will give out errors for missing YamiVersion.h when build dir is different from source dir.

Signed-off-by: Anuj Mittal anuj.mittal@intel.com

xuguangxin commented 6 years ago

@anujm1, thanks for patch Could you help provide the build command you used. So I can reproduce your issue? Also, attach some build command in commit log may help other people know why we need this.

thanks

anujm1 commented 6 years ago

I am building in Yocto. The build is unable to find generated yamiversion.h present in the builddir. Thanks!

| x86_64-poky-linux-libtool: compile: x86_64-poky-linux-g++ -m64 -march=corei7 -mtune=corei7 -mfpmath=sse -msse4.2 --sysroot=/build/tmp/work/corei7-64-poky-linux/libyami/1.3.0-r0/recipe-sysroot -DHAVE_CONFIG_H -I. -I../../git/common -I.. -I../../git/interface -I../../git -g -O2 -Wall -Wno-unused-function -Wno-cpp -Wno-missing-braces -Werror -O2 -pipe -g -feliminate-unused-debug-types -fdebug-prefix-map=/build/tmp/work/corei7-64-poky-linux/libyami/1.3.0-r0=/usr/src/debug/libyami/1.3.0-r0 -fdebug-prefix-map=/tmp/work/corei7-64-poky-linux/libyami/1.3.0-r0/recipe-sysroot-native= -fdebug-prefix-map=/build/tmp/work/corei7-64-poky-linux/libyami/1.3.0-r0/recipe-sysroot= -fvisibility-inlines-hidden -c ../../git/common/YamiVersion.cpp -fPIC -DPIC -o .libs/libyami_common_la-YamiVersion.o | ../../git/common/YamiVersion.cpp:21:10: fatal error: YamiVersion.h: No such file or directory | #include "YamiVersion.h" | ^~~~~~~ | compilation terminated. | Makefile:617: recipe for target 'libyami_common_la-YamiVersion.lo' failed

xuguangxin commented 6 years ago

thanks, let double check with @uartie then merge the patch @uartie , just want double confirm with you. Do you happen to know the builddir and srcdir things?