search

intel / libyami

Yet Another Media Infrastructure. it is core part of media codec with hardware acceleration, it is yummy to your video experience on Linux like platform.
Apache License 2.0
146 stars 106 forks source link

fix coverity bug #840

Closed wangzj0601 closed 6 years ago

wangzj0601 commented 6 years ago

@xuguangxin it should has a memory leak after "assert", so I delete the variable at a wrong position before, and I change it like this now, what do you think about it?

xuguangxin commented 6 years ago

this wired , the assert will abort the program, right? why we need handle memory leak at abort

uartie commented 6 years ago

this wired , the assert will abort the program, right? why we need handle memory leak at abort

@xuguangxin the ASSERT_TRUE only aborts the test case, not the entire test program.

xuguangxin commented 6 years ago

thanks U.Artie for explain

uartie commented 6 years ago

@wangzj0601 thanks for fixing and revising the contents of your patch.

However, the commit message is too vague and not useful. It is not a "coverity bug"... it is a yami test bug. Please describe in the commit message what it is you are actually doing to the code and why it is necessary.