intel / lkp-tests

Linux Kernel Performance tests
GNU General Public License v2.0
258 stars 156 forks source link

Suggest using the `Closes:` tag instead of the `Link:` one #299

Closed matttbe closed 1 year ago

matttbe commented 1 year ago

Francesco @dolcini reported that when adding the following tags suggested in a bug report from LKP...

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202305152341.oiSjRpv6-lkp@intel.com/

... checkpatch.pl is now complaining about the Link: tag:

WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
#8:
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/oe-kbuild-all/202305152341.oiSjRpv6-lkp@intel.com/
total: 0 errors, 1 warnings, 8 lines checked

As explained in my answer to Francesco's question, the expected behaviour is now to use a Closes: tag instead of Link: after the Reported-by: one.

Could it be possible to replace the Link: tag by a Closes: one in the automated reply please? e.g.

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202305152341.oiSjRpv6-lkp@intel.com/
rli9 commented 1 year ago

Thanks a lot for the suggestion, we have updated the report logic. One report is https://lore.kernel.org/oe-kbuild-all/202305171417.toyqGJG3-lkp@intel.com/.

matttbe commented 1 year ago

Hi @rli9,

Thank you for having updated the report template so quickly!

I guess we can close this ticket.