search

intel / llvm-test-suite

Other
20 stars 131 forks source link

[SYCL] Reflect updates to get_pointer return type to relevant tests. #1670

Closed mmoadeli closed 1 year ago

mmoadeli commented 1 year ago

Reflect updates to get_pointer return type to relevant tests. https://github.com/intel/llvm/pull/8493/

mmoadeli commented 1 year ago

@aelovikov-intel, thanks for the comments. An argument of async_work_group_copy is local_ptr which is a multi_ptr. In multi_ptr class there is an implicit conversion from local_accessor to multi_ptr. The updates made in the corresponding PR changed the return type of get_pointer from local_ptr to T*. The changes in this PR provides local_ptr which is needed by async_work_group_copy.

aelovikov-intel commented 1 year ago

An argument of async_work_group_copy is local_ptr

In the specification or in the implementation? Because per the spec at https://registry.khronos.org/SYCL/specs/sycl-2020/html/sycl-2020.html#table.members.nditem, all of the overloads have some kind of decorated_*_ptr which is a multi_ptr with decorated::yes template parameter while local_ptr's default value is legacy.