search

intel / llvm

Intel staging area for llvm.org contribution. Home for Intel LLVM-based projects.
Other
1.26k stars 740 forks source link

Some basic tests should be gated when not configured with --cuda or --hip #12091

Open keryell opened 11 months ago

keryell commented 11 months ago

Describe the bug

The CI runs by default with --cuda --hip configuration which hides some bugs when not compiling with these options. https://github.com/intel/llvm/actions/runs/7107844414/job/19350224693?pr=12087#step:7:18

Failing tests when no --cuda or --hip:

  Clang :: Driver/sycl-offload-amdgcn.cpp
  Clang :: Driver/sycl-oneapi-gpu.cpp
  Clang :: Driver/sycl-triple-dae-flags.cpp
  Clang :: Driver/sycl-unsupported-arch.cpp
  Clang :: SemaSYCL/lb_sm_90.cpp

I have the feeling these tests should not run in that case or should be updated.

To Reproduce

python3 $DPCPP_HOME/llvm/buildbot/configure.py --shared-libs
python3 $DPCPP_HOME/llvm/buildbot/compile.py --verbose
cmake --build $DPCPP_HOME/llvm/build --target check-clang

Environment (please complete the following information):

AlexeySachkov commented 9 months ago

At least some of those should be addressed by #12505