search

intel / llvm

Intel staging area for llvm.org contribution. Home for Intel LLVM-based projects.
Other
1.26k stars 741 forks source link

Select device for FPGA specific attributes since `intelfpga` namespace was deprecated in favor of just intel namespace #2740

Open smanna12 opened 4 years ago

smanna12 commented 4 years ago

Previously we had FPGA specific attributes in intelfpga namespace, so it was pretty much obvious to which device they belong. Now when intelfpga was deprecated in favor of just intel namespace we can re-consider texts in some warnings etc, but it can be done in a separate patch.

_Originally posted by @MrSidims in https://github.com/intel/llvm/pull/2734#discussion_r518675525_

smanna12 commented 4 years ago

@MrSidims Could you please elaborate what do you mean to say here? We already have deprecated warning for [[intelfpga::...]] spelling. I could not locate the source codes where we are selecting the device for FPGA specific attributes.

MrSidims commented 4 years ago

@smanna12 my comment was an answer to this one: https://github.com/intel/llvm/pull/2734#discussion_r518153650

MrSidims commented 4 years ago

So, what I mean is: FPGA hardware is kinda different from CPU and many developers are unfamiliar with it (for example Mary aknowledge that). Previously these attributes were placed in intelfpga:: namespace, so it was obvious to which device they serve. Now, when we depreceted intelfpga:: namespace in favor of intel:: namespace (which doesn't explicitly state for what device a particular attribute is implemented), it would be good to go through docs/warnings and add a note about FPGA device (so texts that describes some H/W specific logic wouldn't be looking like some wierd magic :) ).