search

intel / media-driver

Intel Graphics Media Driver to support hardware decode, encode and video processing.
https://github.com/intel/media-driver/wiki
Other
1.01k stars 346 forks source link

[Decode] Remove av1 decode from feature list on some platforms #1853

Closed Jexu closed 1 month ago

Jexu commented 2 months ago

Fixes: #1852, #1832 Av1 decode needs filmgrain kernel support, and free kernel build will not support av1 decode.

nyanmisaka commented 1 month ago 
.adv0Decoding   = SET_STATUS_BY_FULL_OPEN_SOURCE(1, 0),
.adv1Decoding   = SET_STATUS_BY_FULL_OPEN_SOURCE(1, 0),

Wouldn't it be more intuitive to set these to media_driver/linux/{gen12,Xe_M}/ddi/media_sku_wa_{g12,xe}.cpp?

This would make libva not report AV1 decoding support in the so-called "free" driver, instead of crashing the video player or libavcodec when vaapi decoding is invoked. So as the downstream can fallback to using the software decoder gracefully.

https://github.com/mpv-player/mpv/issues/14941

okias commented 1 month ago

@Jexu ^ + https://trac.ffmpeg.org/ticket/11213 . IMHO Avoiding the crash itself should be part of the change.