Implementation questions

[M4tteoP]

Hi there, I'm going through the static .cc file and I was wondering about some implementations:

• Is there a special reason behind relying on dynamic allocation and pointers instead of directly create the variables inside the class? I'm referring about modsec_, modsecrules and modsec_transaction_.
• https://github.com/intel/modsecurity-wasm-filter/blob/648b78f74a6bccc6f79883d5903f8c511c77f93e/wasmplugin/envoy-wasm-modsecurity.cc#L291-L293 This code about handling 302 status during an intervention, when should it happen? Are there any specific use cases?
• https://github.com/intel/modsecurity-wasm-filter/blob/648b78f74a6bccc6f79883d5903f8c511c77f93e/wasmplugin/envoy-wasm-modsecurity.cc#L360-L365 I was aware that writing logs into a file from inside the Wasm filter was not supported. How does this code work? Is it actually possible to make it work?

Thanks!

[bryanwux]

@leyao-daily

[leyao-daily]

• No special reason, we use them like the community document examples.
• No specified user cases, just to handle the status for potential precession.
• We did validate it with very simple testing, it works. Maybe we haven't fully tested it.

I think there maybe some code changes in the future to get the performance better. LOL

[M4tteoP]

Thank you!

We did validate it with very simple testing, it works. Maybe we haven't fully tested it.

Maybe I'm just missing something about it. It should write hello world inside the file system at /etc/modsecurity_audit.log just running the filter and triggering an internvetion; is it right? I'm testing it, but I am not able to reproduce that behaviour. Thanks for any clarification about that, having access to the file system would be so cool and needed!