Added a missing `const` qualifier

intel / mpi-benchmarks

149 stars 63 forks source link

Closed kawashima-fj closed 10 months ago

kawashima-fj commented 5 years ago

The type of args_parser::expected_args and the type of it in args_parser::in_expected_args are incompatible. The former lacks const. This causes a compilation error with libc++ (e.g. use clang++ with CXXFLAGS=-stdlib=libc++).

My colleague reported this as a bug of libc++ but a maintainer answered that this is a bug in IMB.

kawashima-fj commented 4 years ago

Ping. Can this and #20 be merged? If they are issues of Clang or libc++, please let me know.

JuliaRS commented 10 months ago

This changes have already unstreamed in product. Thank you for contribution :)