search

intel / mpi-benchmarks

146 stars 63 forks source link

Small makefile fix #8

Closed a-v-medvedev closed 5 years ago

a-v-medvedev commented 6 years ago

Here are two small fixes for a main Makefile placed in the src_cpp/ directory.

  1. Shell command syntax in announcement target rules are not portable, so they may fail on some systems. The offered replacement uses older shell syntax to make sure it works everywhere.
  2. There was -O0 optimization flag which is looks odd for release software; the -Wextra and -pedantic flags for C-files produce a lot of growling from compiler on legacy IMB code which is probably of no use since this code hardly is going to develop anymore. If these flags are removed, there are much less warnings (at least on on GCC 4.7).
SergeyGubanov commented 5 years ago

@a-v-medvedev,

Thank you for the contribution. This pull request will be handled using corporate requirements and guidelines. It will be pushed in one of upcoming releases, with corresponding notes in Release Notes (What’s New section). As soon the release is out, this pull request will be closed.

VinnitskiV commented 5 years ago

Fixed