Closed wanghongjuan closed 6 years ago
@kenny-y Could you please take a look?
@wanghongjuan there are some lint error in JavaScript files. I know we leveraged some UI files from PerC's native sample. Those files can be out of the lint scope, but we need to make sure the code made by ourselves should passed the lint tool.
@DonnaWuDongxia Thanks for your comment, I will format the code to conform the lint tool
@DonnaWuDongxia I updated the code, please take a look. Thanks
@DonnaWuDongxia I fixed the lint error in js files, see detail information:
Missing trailing comma
, when only one property or the last property is listed in a array
doesn't need to add the trailing commawarning
: won't fix'xxx' is defined but never used
, this variable is used in other file'xxx' is assigned a value but never used
, this variable is used in other fileMeanwhile, I found one weird thing: Same code in different file, the checked result using eslint is different, one is an error, other is a warning.
@wanghongjuan Great work! I'm merging it.