intel / node-realsense

MIT License
24 stars 21 forks source link

[samples] add ocf realsense samples #229

Closed wanghongjuan closed 6 years ago

wanghongjuan commented 6 years ago
wanghongjuan commented 6 years ago

@kenny-y Could you please take a look?

DonnaWuDongxia commented 6 years ago

@wanghongjuan there are some lint error in JavaScript files. I know we leveraged some UI files from PerC's native sample. Those files can be out of the lint scope, but we need to make sure the code made by ourselves should passed the lint tool.

wanghongjuan commented 6 years ago

@DonnaWuDongxia Thanks for your comment, I will format the code to conform the lint tool

wanghongjuan commented 6 years ago

@DonnaWuDongxia I updated the code, please take a look. Thanks

wanghongjuan commented 6 years ago

@DonnaWuDongxia I fixed the lint error in js files, see detail information:

Meanwhile, I found one weird thing: Same code in different file, the checked result using eslint is different, one is an error, other is a warning.

view js
DonnaWuDongxia commented 6 years ago

@wanghongjuan Great work! I'm merging it.