intel / numatop

NumaTOP is an observation tool for runtime memory locality characterization and analysis of processes and threads running on a NUMA system.
BSD 3-Clause "New" or "Revised" License
197 stars 47 forks source link

Fix the i686 build with hardening #5

Closed dridi closed 11 years ago

dridi commented 11 years ago

This is a follow-up of issues #3 and #4 that solve several problems for hardened builds, but not the cpuid part.

The cpuid fix doesn't solve the asm issue, and @keszybz accidentally tested a numactl build. This pull request reverts all the changes made for the issue #3 and fixes the i686 hardened build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5934627

I have tested the output of cpuid on the (limited) hardware I own, and it's the same with or without this patch.

yaoj commented 11 years ago

Merged this pull request.

Thanks Jin Yao

From: Dridi Boukelmoune [mailto:notifications@github.com] Sent: Saturday, September 14, 2013 7:25 PM To: 01org/numatop Subject: [numatop] Fix the i686 build with hardening (#5)

This is a follow-up of issues #3https://github.com/01org/numatop/issues/3 and #4https://github.com/01org/numatop/pull/4 that solve several problems for hardened builds, but not the cpuid part.

The cpuid fix doesn't solve the asm issue, and @keszybzhttps://github.com/keszybz accidentally tested a numactl build. This pull request reverts all the changes made for the issue #3https://github.com/01org/numatop/issues/3 and fixes the i686 hardened build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5934627

I have tested the output of cpuid on the (limited) hardware I own, and it's the same with or without this patch.


You can merge this Pull Request by running

git pull https://github.com/Dridi/numatop master

Or view, comment on, or merge it at:

https://github.com/01org/numatop/pull/5

Commit Summary

File Changes

Patch Links: