yaoj
commented
11 years ago Merged this pull request.
Thanks Jin Yao
From: Dridi Boukelmoune [mailto:notifications@github.com] Sent: Saturday, September 14, 2013 7:25 PM To: 01org/numatop Subject: [numatop] Fix the i686 build with hardening (#5)
This is a follow-up of issues #3https://github.com/01org/numatop/issues/3 and #4https://github.com/01org/numatop/pull/4 that solve several problems for hardened builds, but not the cpuid part.
The cpuid fix doesn't solve the asm issue, and @keszybzhttps://github.com/keszybz accidentally tested a numactl build. This pull request reverts all the changes made for the issue #3https://github.com/01org/numatop/issues/3 and fixes the i686 hardened build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5934627
I have tested the output of cpuid on the (limited) hardware I own, and it's the same with or without this patch.
You can merge this Pull Request by running
git pull https://github.com/Dridi/numatop master
Or view, comment on, or merge it at:
https://github.com/01org/numatop/pull/5
Commit Summary
- Revert "Change cpuid substitute to solve the fedora packaging build error."
- Revert "Substitute "a" in the input list by "0""
- Revert "Use the _cpuid in
" - Preserve the ebx register in 32bit cpuid
File Changes
- M common/util.chttps://github.com/01org/numatop/pull/5/files#diff-0 (37)
Patch Links:
This is a follow-up of issues #3 and #4 that solve several problems for hardened builds, but not the cpuid part.
The cpuid fix doesn't solve the asm issue, and @keszybz accidentally tested a numactl build. This pull request reverts all the changes made for the issue #3 and fixes the i686 hardened build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5934627
I have tested the output of cpuid on the (limited) hardware I own, and it's the same with or without this patch.