intel / numatop

NumaTOP is an observation tool for runtime memory locality characterization and analysis of processes and threads running on a NUMA system.
BSD 3-Clause "New" or "Revised" License
197 stars 47 forks source link

numatop/powerpc: Add power10 support #67

Closed kjain101 closed 11 months ago

kjain101 commented 1 year ago

Add platform check for power10 processors. Add new files called power10.c/power10.h, which includes addition of the relevant events, to count per-process/per-thread memory accesses and CPU usage information for power10 processors.

kjain101 commented 1 year ago

Hi @tzhang449 @ZhengjunXing @zhenyw Looking for review comments. Please let me know if the changes in this pull request looks fine to you. In this pull request we are adding power10 support for numatop.

Thanks, Kajol Jain

tehcaster commented 1 year ago

+1 any plans to merge this and release a v2.4 soon?

shirishaganta1 commented 1 year ago

Hi, Verified the above patch series on P10 and it is working as expected # ./numatop NumaTOP is starting ... NumaTOP is exiting ... # NumaTOP v2.3, (C) 2022 Intel Corporation

Monitoring 543 processes and 591 threads (interval: 5.0s)

PID PROC RMA(K) LMA(K) RMA/LMA CPI *CPU% 4465 numatop 0.2 0.9 0.2 0.73 0.0 1 systemd 0.0 0.0 0.0 0.00 0.0 2 kthreadd 0.0 0.0 0.0 0.00 0.0 3 pool_workqu 0.0 0.0 0.0 0.00 0.0 4 kworker/R-r 0.0 0.0 0.0 0.00 0.0 5 kworker/R-r 0.0 0.0 0.0 0.00 0.0 6 kworker/R-s 0.0 0.0 0.0 0.00 0.0 7 kworker/R-n 0.0 0.0 0.0 0.00 0.0 8 kworker/0:0 0.0 0.0 0.0 0.00 0.0 10 kworker/0:0 0.0 0.0 0.0 0.00 0.0 11 kworker/u64 0.0 0.0 0.0 0.00 0.0 12 kworker/R-m 0.0 0.0 0.0 0.00 0.0 13 rcu_tasks_r 0.0 0.0 0.0 0.00 0.0 14 rcu_tasks_t 0.0 0.0 0.0 0.00 0.0 15 ksoftirqd/0 0.0 0.0 0.0 0.00 0.0 16 rcu_sched 0.0 0.0 0.0 0.00 0.0 17 migration/0 0.0 0.0 0.0 0.00 0.0 18 cpuhp/0 0.0 0.0 0.0 0.00 0.0 19 cpuhp/1 0.0 0.0 0.0 0.00 0.0 20 migration/1 0.0 0.0 0.0 0.00 0.0 21 ksoftirqd/1 0.0 0.0 0.0 0.00 0.0 23 kworker/1:0 0.0 0.0 0.0 0.00 0.0 24 cpuhp/2 0.0 0.0 0.0 0.00 0.0 25 migration/2 0.0 0.0 0.0 0.00 0.0 26 ksoftirqd/2 0.0 0.0 0.0 0.00 0.0 27 kworker/2:0 0.0 0.0 0.0 0.00 0.0 28 kworker/2:0 0.0 0.0 0.0 0.00 0.0 29 cpuhp/3 0.0 0.0 0.0 0.00 0.0 30 migration/3 0.0 0.0 0.0 0.00 0.0 31 ksoftirqd/3 0.0 0.0 0.0 0.00 0.0 33 kworker/3:0 0.0 0.0 0.0 0.00 0.0

<- Hotkey for sorting: 1(RMA), 2(LMA), 3(RMA/LMA), 4(CPI), 5(CPU%) -> CPU% = system CPU utilization

Q: Quit; H: Home; R: Refresh; I: IR Normalize; N: Node

Node Overview (interval: 5.0s)

NODE MEM.ALL MEM.FREE RMA(K) LMA(K) RMA/LMA CPU% 0 25.0G 22.7G 0.1 0.4 0.2 0.0 1 24.2G 23.9G 0.0 0.0 0.0 0.0 2 18.2G 17.9G 0.0 0.0 0.0 0.0 3 30.2G 29.9G 0.0 0.0 0.0 0.0

Thanks, Shirisha

kjain101 commented 12 months ago

@tzhang449 @ZhengjunXing @zhenyw @tehcaster any outlook on when Numatop 2.4 will be available?

shirishaganta1 commented 12 months ago

Tested the above patch.. tested-by: Shirisha Ganta shirisha@linux.ibm.com

tzhang449 commented 11 months ago

Hi @kjain101 , I will work on updating Numatop to 2.4 later. This patch is clean on Intel platform, I will merge it.

kjain101 commented 11 months ago

Thanks @tzhang449