search

intel / numatop

NumaTOP is an observation tool for runtime memory locality characterization and analysis of processes and threads running on a NUMA system.
BSD 3-Clause "New" or "Revised" License
197 stars 47 forks source link

Squash default GCC warnings on Fedora 39 #71

Closed dridi closed 3 months ago

dridi commented 7 months ago

There are two more when building with Clang, but this first batch is already a handful.

ak-intel commented 3 months ago

I picked up some of your patches, others were already fixed. Sorry for the late merge.

dridi commented 3 months ago

I think you can revert https://github.com/intel/numatop/commit/5509f2830b5376ff24690b7bed076053db25232c since the format strings were also added in https://github.com/intel/numatop/commit/635e2ce2ccb1ac793cc276a7fcb8a92b1ffefa5d, there should be no warning left to silence for GCC.

Out of curiosity, why not pick c46ebd47907a77bfbcfa5ac8dacf7536102ae3af ? It's trivial and much less prone to error than the current construct.

I reckon https://github.com/intel/numatop/pull/71/commits/48a9a5597c638ca580458753fba564f0cfe248ea is not as straightforward and I'm not too surprised it was omitted, but I'm also curious why.

Thank you for taking the time to review this patch series.

ak-intel commented 3 months ago

I applied them all now. Thanks.

-andi