search

intel / numatop

NumaTOP is an observation tool for runtime memory locality characterization and analysis of processes and threads running on a NUMA system.
BSD 3-Clause "New" or "Revised" License
199 stars 48 forks source link

build failure due to commit cf9ca3853a2c801fe04d9bf6d4e2698a00d6de79 #78

Closed ColinIanKing closed 3 months ago

ColinIanKing commented 3 months ago

I'm getting a build failure when building from tip commit cf9ca3853a2c801fe04d9bf6d4e2698a00d6de79 (HEAD -> master, origin/master, origin/HEAD)

The problematic commit is: cf9ca3853a2c801fe04d9bf6d4e2698a00d6de79 Author: Dridi Boukelmoune dridi.boukelmoune@gmail.com Date: Mon Mar 4 23:11:13 2024 +0100

common: Build node string with bound checks

A print_buf() function is added to keep track of progress inside the s1
buffer and the remaining space. With s1 acting as a cursor and vsnprintf
taking care of formatting, the temp buffers s2 and s3 are no longer
needed.

This silences the stringop-overflow warning.

The build failure is:

make[1]: Entering directory '/home/cking/repos/numatop'
  CC       common/os/os_win.lo
common/os/os_win.c: In function 'node_cpu_string':
common/os/os_win.c:177:45: error: 's2' undeclared (first use in this function); did you mean 's1'?
  177 |                         int s2_len = sizeof(s2);
      |                                             ^~
      |                                             s1
common/os/os_win.c:177:45: note: each undeclared identifier is reported only once for each function it appears in
common/os/os_win.c:177:29: warning: variable 's2_len' set but not used [-Wunused-but-set-variable]
  177 |                         int s2_len = sizeof(s2);
      |                             ^~~~~~
common/os/os_win.c:142:13: warning: unused variable 's1_len' [-Wunused-variable]
  142 |         int s1_len = size;
      |             ^~~~~~
make[1]: *** [Makefile:1015: common/os/os_win.lo] Error 1
make[1]: Leaving directory '/home/cking/repos/numatop'
make: *** [Makefile:694: all] Error 2
ak-intel commented 3 months ago

Are you sure you don’t have local changes or some conflict?

175 if (cpuid_arr[j] != cpuid_start + l) { 176 if (k < ncpus) { 177 if (l == 1) { 178 print_buf(&s1, &size, "%d ", cpuid_start); 179 } else {

There is no reference to s2_len, the variable doesn’t exist anymore.

-Andi

From: Colin Ian King @.> Sent: Thursday, August 1, 2024 1:18 AM To: intel/numatop @.> Cc: Subscribed @.***> Subject: [intel/numatop] build failure due to commit cf9ca3853a2c801fe04d9bf6d4e2698a00d6de79 (Issue #78)

I'm getting a build failure when building from tip commit cf9ca38https://github.com/intel/numatop/commit/cf9ca3853a2c801fe04d9bf6d4e2698a00d6de79 (HEAD -> master, origin/master, origin/HEAD)

The problematic commit is: cf9ca38https://github.com/intel/numatop/commit/cf9ca3853a2c801fe04d9bf6d4e2698a00d6de79 Author: Dridi Boukelmoune @.**@.> Date: Mon Mar 4 23:11:13 2024 +0100

common: Build node string with bound checks

A print_buf() function is added to keep track of progress inside the s1

buffer and the remaining space. With s1 acting as a cursor and vsnprintf

taking care of formatting, the temp buffers s2 and s3 are no longer

needed.

This silences the stringop-overflow warning.

The build failure is:

make[1]: Entering directory '/home/cking/repos/numatop'

CC common/os/os_win.lo

common/os/os_win.c: In function 'node_cpu_string':

common/os/os_win.c:177:45: error: 's2' undeclared (first use in this function); did you mean 's1'?

177 | int s2_len = sizeof(s2);

  |                                             ^~

  |                                             s1

common/os/os_win.c:177:45: note: each undeclared identifier is reported only once for each function it appears in

common/os/os_win.c:177:29: warning: variable 's2_len' set but not used [-Wunused-but-set-variable]

177 | int s2_len = sizeof(s2);

  |                             ^~~~~~

common/os/os_win.c:142:13: warning: unused variable 's1_len' [-Wunused-variable]

142 | int s1_len = size;

  |             ^~~~~~

make[1]: *** [Makefile:1015: common/os/os_win.lo] Error 1

make[1]: Leaving directory '/home/cking/repos/numatop'

make: *** [Makefile:694: all] Error 2

— Reply to this email directly, view it on GitHubhttps://github.com/intel/numatop/issues/78, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATOPPO2H6N5KENLJQYSVYJDZPHVMHAVCNFSM6AAAAABL2BATP6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ2DCNZZGU3TSOA. You are receiving this because you are subscribed to this thread.Message ID: @.***>

ColinIanKing commented 3 months ago

pretty sure, this is from a new clone of the repo:

git clone https://github.com/intel/numatop.git
Cloning into 'numatop'...
remote: Enumerating objects: 1147, done.
remote: Counting objects: 100% (175/175), done.
remote: Compressing objects: 100% (54/54), done.
remote: Total 1147 (delta 135), reused 132 (delta 121), pack-reused 972
Receiving objects: 100% (1147/1147), 477.99 KiB | 2.12 MiB/s, done.
Resolving deltas: 100% (826/826), done.
cking@t480:~/repos$ cd numatop
cking@t480:~/repos/numatop$ ./autogen.sh 
aclocal: warning: couldn't open directory 'm4': No such file or directory
libtoolize: putting auxiliary files in '.'.
libtoolize: linking file './ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
libtoolize: linking file 'm4/libtool.m4'
libtoolize: linking file 'm4/ltoptions.m4'
libtoolize: linking file 'm4/ltsugar.m4'
libtoolize: linking file 'm4/ltversion.m4'
libtoolize: linking file 'm4/lt~obsolete.m4'
configure.ac:9: installing './compile'
configure.ac:9: installing './config.guess'
configure.ac:9: installing './config.sub'
configure.ac:6: installing './install-sh'
configure.ac:6: installing './missing'
Makefile.am: installing './depcomp'
parallel-tests: installing './test-driver'
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a race-free mkdir -p... /usr/bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking build system type... x86_64-pc-linux-gnu
checking host system type... x86_64-pc-linux-gnu
checking how to print strings... printf
checking whether make supports the include directive... yes (GNU style)
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether the compiler supports GNU C... yes
checking whether gcc accepts -g... yes
checking for gcc option to enable C11 features... none needed
checking whether gcc understands -c and -o together... yes
checking dependency style of gcc... gcc3
checking for a sed that does not truncate output... /usr/bin/sed
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking for fgrep... /usr/bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 1572864
checking how to convert x86_64-pc-linux-gnu file names to x86_64-pc-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-pc-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for file... file
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for ar... ar
checking for archiver @FILE support... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for sysroot... no
checking for a working dd... /usr/bin/dd
checking how to truncate binary pipes... /usr/bin/dd bs=4096 count=1
checking for mt... mt
checking if mt is a manifest tool... no
checking for stdio.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for strings.h... yes
checking for sys/stat.h... yes
checking for sys/types.h... yes
checking for unistd.h... yes
checking for sys/param.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
checking for gcc... (cached) gcc
checking whether the compiler supports GNU C... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to enable C11 features... (cached) none needed
checking whether gcc understands -c and -o together... (cached) yes
checking dependency style of gcc... (cached) gcc3
checking for numa_free in -lnuma... yes
checking for pthread_create in -lpthread... yes
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for check... yes
checking for ncursesw ncurses... yes
checking for fcntl.h... yes
checking for inttypes.h... (cached) yes
checking for limits.h... yes
checking for locale.h... yes
checking for stddef.h... yes
checking for stdint.h... (cached) yes
checking for stdlib.h... (cached) yes
checking for string.h... (cached) yes
checking for strings.h... (cached) yes
checking for sys/ioctl.h... yes
checking for sys/time.h... yes
checking for unistd.h... (cached) yes
checking for int64_t... yes
checking for pid_t... yes
checking for size_t... yes
checking for uint32_t... yes
checking for uint64_t... yes
checking for GNU libc compatible malloc... yes
checking for getpagesize... yes
checking for working mmap... yes
checking for GNU libc compatible realloc... yes
checking for working strtod... yes
checking for getpagesize... (cached) yes
checking for gettimeofday... yes
checking for memset... yes
checking for munmap... yes
checking for select... yes
checking for strcasecmp... yes
checking for strchr... yes
checking for strcspn... yes
checking for strstr... yes
checking for strtol... yes
checking for strtoull... yes
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating config.h
config.status: executing depfiles commands
config.status: executing libtool commands
 rm -f numatop
rm -rf .libs _libs
rm -rf common/.libs common/_libs
rm -rf common/os/.libs common/os/_libs
rm -rf powerpc/.libs powerpc/_libs
rm -rf x86/.libs x86/_libs
test -z "libnumatop.la" || rm -f libnumatop.la
rm -f ./so_locations
 rm -f mgen
rm -f *.o
rm -f common/*.o
rm -f common/*.lo
rm -f common/os/*.o
rm -f common/os/*.lo
rm -f powerpc/*.o
rm -f powerpc/*.lo
rm -f test/mgen/*.o
rm -f test/mgen/powerpc/*.o
rm -f test/mgen/x86/*.o
rm -f x86/*.o
rm -f x86/*.lo
test -z "test/mgen.01.sh.log test/mgen.02.sh.log" || rm -f test/mgen.01.sh.log test/mgen.02.sh.log
test -z "test/mgen.01.sh.trs test/mgen.02.sh.trs" || rm -f test/mgen.01.sh.trs test/mgen.02.sh.trs
test -z "test-suite.log" || rm -f test-suite.log
rm -f *.lo
cking@t480:~/repos/numatop$ ./configure 
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a race-free mkdir -p... /usr/bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking build system type... x86_64-pc-linux-gnu
checking host system type... x86_64-pc-linux-gnu
checking how to print strings... printf
checking whether make supports the include directive... yes (GNU style)
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether the compiler supports GNU C... yes
checking whether gcc accepts -g... yes
checking for gcc option to enable C11 features... none needed
checking whether gcc understands -c and -o together... yes
checking dependency style of gcc... gcc3
checking for a sed that does not truncate output... /usr/bin/sed
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking for fgrep... /usr/bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 1572864
checking how to convert x86_64-pc-linux-gnu file names to x86_64-pc-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-pc-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for file... file
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for ar... ar
checking for archiver @FILE support... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for sysroot... no
checking for a working dd... /usr/bin/dd
checking how to truncate binary pipes... /usr/bin/dd bs=4096 count=1
checking for mt... mt
checking if mt is a manifest tool... no
checking for stdio.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for strings.h... yes
checking for sys/stat.h... yes
checking for sys/types.h... yes
checking for unistd.h... yes
checking for sys/param.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
checking for gcc... (cached) gcc
checking whether the compiler supports GNU C... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to enable C11 features... (cached) none needed
checking whether gcc understands -c and -o together... (cached) yes
checking dependency style of gcc... (cached) gcc3
checking for numa_free in -lnuma... yes
checking for pthread_create in -lpthread... yes
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for check... yes
checking for ncursesw ncurses... yes
checking for fcntl.h... yes
checking for inttypes.h... (cached) yes
checking for limits.h... yes
checking for locale.h... yes
checking for stddef.h... yes
checking for stdint.h... (cached) yes
checking for stdlib.h... (cached) yes
checking for string.h... (cached) yes
checking for strings.h... (cached) yes
checking for sys/ioctl.h... yes
checking for sys/time.h... yes
checking for unistd.h... (cached) yes
checking for int64_t... yes
checking for pid_t... yes
checking for size_t... yes
checking for uint32_t... yes
checking for uint64_t... yes
checking for GNU libc compatible malloc... yes
checking for getpagesize... yes
checking for working mmap... yes
checking for GNU libc compatible realloc... yes
checking for working strtod... yes
checking for getpagesize... (cached) yes
checking for gettimeofday... yes
checking for memset... yes
checking for munmap... yes
checking for select... yes
checking for strcasecmp... yes
checking for strchr... yes
checking for strcspn... yes
checking for strstr... yes
checking for strtol... yes
checking for strtoull... yes
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating config.h
config.status: config.h is unchanged
config.status: executing depfiles commands
config.status: executing libtool commands
cking@t480:~/repos/numatop$ make
make  all-am
make[1]: Entering directory '/home/cking/repos/numatop'
gcc -DHAVE_CONFIG_H -I.    -D_DEFAULT_SOURCE -D_XOPEN_SOURCE=600  -g -O2 -MT common/numatop-numatop.o -MD -MP -MF common/.deps/numatop-numatop.Tpo -c -o common/numatop-numatop.o `test -f 'common/numatop.c' || echo './'`common/numatop.c
mv -f common/.deps/numatop-numatop.Tpo common/.deps/numatop-numatop.Po
depbase=`echo common/os/map.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
/bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.    -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/map.lo -MD -MP -MF $depbase.Tpo -c -o common/os/map.lo common/os/map.c &&\
mv -f $depbase.Tpo $depbase.Plo
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/map.lo -MD -MP -MF common/os/.deps/map.Tpo -c common/os/map.c  -fPIC -DPIC -o common/os/.libs/map.o
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/map.lo -MD -MP -MF common/os/.deps/map.Tpo -c common/os/map.c -o common/os/map.o >/dev/null 2>&1
depbase=`echo common/os/node.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
/bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.    -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/node.lo -MD -MP -MF $depbase.Tpo -c -o common/os/node.lo common/os/node.c &&\
mv -f $depbase.Tpo $depbase.Plo
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/node.lo -MD -MP -MF common/os/.deps/node.Tpo -c common/os/node.c  -fPIC -DPIC -o common/os/.libs/node.o
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/node.lo -MD -MP -MF common/os/.deps/node.Tpo -c common/os/node.c -o common/os/node.o >/dev/null 2>&1
depbase=`echo common/os/os_cmd.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
/bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.    -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/os_cmd.lo -MD -MP -MF $depbase.Tpo -c -o common/os/os_cmd.lo common/os/os_cmd.c &&\
mv -f $depbase.Tpo $depbase.Plo
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/os_cmd.lo -MD -MP -MF common/os/.deps/os_cmd.Tpo -c common/os/os_cmd.c  -fPIC -DPIC -o common/os/.libs/os_cmd.o
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/os_cmd.lo -MD -MP -MF common/os/.deps/os_cmd.Tpo -c common/os/os_cmd.c -o common/os/os_cmd.o >/dev/null 2>&1
depbase=`echo common/os/os_page.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
/bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.    -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/os_page.lo -MD -MP -MF $depbase.Tpo -c -o common/os/os_page.lo common/os/os_page.c &&\
mv -f $depbase.Tpo $depbase.Plo
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/os_page.lo -MD -MP -MF common/os/.deps/os_page.Tpo -c common/os/os_page.c  -fPIC -DPIC -o common/os/.libs/os_page.o
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/os_page.lo -MD -MP -MF common/os/.deps/os_page.Tpo -c common/os/os_page.c -o common/os/os_page.o >/dev/null 2>&1
depbase=`echo common/os/os_perf.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
/bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.    -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/os_perf.lo -MD -MP -MF $depbase.Tpo -c -o common/os/os_perf.lo common/os/os_perf.c &&\
mv -f $depbase.Tpo $depbase.Plo
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/os_perf.lo -MD -MP -MF common/os/.deps/os_perf.Tpo -c common/os/os_perf.c  -fPIC -DPIC -o common/os/.libs/os_perf.o
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/os_perf.lo -MD -MP -MF common/os/.deps/os_perf.Tpo -c common/os/os_perf.c -o common/os/os_perf.o >/dev/null 2>&1
depbase=`echo common/os/os_util.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
/bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.    -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/os_util.lo -MD -MP -MF $depbase.Tpo -c -o common/os/os_util.lo common/os/os_util.c &&\
mv -f $depbase.Tpo $depbase.Plo
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/os_util.lo -MD -MP -MF common/os/.deps/os_util.Tpo -c common/os/os_util.c  -fPIC -DPIC -o common/os/.libs/os_util.o
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/os_util.lo -MD -MP -MF common/os/.deps/os_util.Tpo -c common/os/os_util.c -o common/os/os_util.o >/dev/null 2>&1
depbase=`echo common/os/os_win.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
/bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.    -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/os_win.lo -MD -MP -MF $depbase.Tpo -c -o common/os/os_win.lo common/os/os_win.c &&\
mv -f $depbase.Tpo $depbase.Plo
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/os_win.lo -MD -MP -MF common/os/.deps/os_win.Tpo -c common/os/os_win.c  -fPIC -DPIC -o common/os/.libs/os_win.o
common/os/os_win.c: In function 'node_cpu_string':
common/os/os_win.c:177:45: error: 's2' undeclared (first use in this function); did you mean 's1'?
  177 |                         int s2_len = sizeof(s2);
      |                                             ^~
      |                                             s1
common/os/os_win.c:177:45: note: each undeclared identifier is reported only once for each function it appears in
common/os/os_win.c:177:29: warning: variable 's2_len' set but not used [-Wunused-but-set-variable]
  177 |                         int s2_len = sizeof(s2);
      |                             ^~~~~~
common/os/os_win.c:142:13: warning: unused variable 's1_len' [-Wunused-variable]
  142 |         int s1_len = size;
      |             ^~~~~~
make[1]: *** [Makefile:1015: common/os/os_win.lo] Error 1
make[1]: Leaving directory '/home/cking/repos/numatop'
make: *** [Makefile:694: all] Error 2
ak-intel commented 3 months ago

Okay fixed

From: Colin Ian King @.> Sent: Thursday, August 1, 2024 1:29 AM To: intel/numatop @.> Cc: Kleen, Andi @.>; Comment @.> Subject: Re: [intel/numatop] build failure due to commit cf9ca3853a2c801fe04d9bf6d4e2698a00d6de79 (Issue #78)

pretty sure, this is from a new clone of the repo:

git clone https://github.com/intel/numatop.git

Cloning into 'numatop'...

remote: Enumerating objects: 1147, done.

remote: Counting objects: 100% (175/175), done.

remote: Compressing objects: 100% (54/54), done.

remote: Total 1147 (delta 135), reused 132 (delta 121), pack-reused 972

Receiving objects: 100% (1147/1147), 477.99 KiB | 2.12 MiB/s, done.

Resolving deltas: 100% (826/826), done.

@.***:~/repos$ cd numatop

@.***:~/repos/numatop$ ./autogen.sh

aclocal: warning: couldn't open directory 'm4': No such file or directory

libtoolize: putting auxiliary files in '.'.

libtoolize: linking file './ltmain.sh'

libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.

libtoolize: linking file 'm4/libtool.m4'

libtoolize: linking file 'm4/ltoptions.m4'

libtoolize: linking file 'm4/ltsugar.m4'

libtoolize: linking file 'm4/ltversion.m4'

libtoolize: linking file 'm4/lt~obsolete.m4'

configure.ac:9: installing './compile'

configure.ac:9: installing './config.guess'

configure.ac:9: installing './config.sub'

configure.ac:6: installing './install-sh'

configure.ac:6: installing './missing'

Makefile.am: installing './depcomp'

parallel-tests: installing './test-driver'

checking for a BSD-compatible install... /usr/bin/install -c

checking whether build environment is sane... yes

checking for a race-free mkdir -p... /usr/bin/mkdir -p

checking for gawk... gawk

checking whether make sets $(MAKE)... yes

checking whether make supports nested variables... yes

checking build system type... x86_64-pc-linux-gnu

checking host system type... x86_64-pc-linux-gnu

checking how to print strings... printf

checking whether make supports the include directive... yes (GNU style)

checking for gcc... gcc

checking whether the C compiler works... yes

checking for C compiler default output file name... a.out

checking for suffix of executables...

checking whether we are cross compiling... no

checking for suffix of object files... o

checking whether the compiler supports GNU C... yes

checking whether gcc accepts -g... yes

checking for gcc option to enable C11 features... none needed

checking whether gcc understands -c and -o together... yes

checking dependency style of gcc... gcc3

checking for a sed that does not truncate output... /usr/bin/sed

checking for grep that handles long lines and -e... /usr/bin/grep

checking for egrep... /usr/bin/grep -E

checking for fgrep... /usr/bin/grep -F

checking for ld used by gcc... /usr/bin/ld

checking if the linker (/usr/bin/ld) is GNU ld... yes

checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B

checking the name lister (/usr/bin/nm -B) interface... BSD nm

checking whether ln -s works... yes

checking the maximum length of command line arguments... 1572864

checking how to convert x86_64-pc-linux-gnu file names to x86_64-pc-linux-gnu format... func_convert_file_noop

checking how to convert x86_64-pc-linux-gnu file names to toolchain format... func_convert_file_noop

checking for /usr/bin/ld option to reload object files... -r

checking for file... file

checking for objdump... objdump

checking how to recognize dependent libraries... pass_all

checking for dlltool... no

checking how to associate runtime and link libraries... printf %s\n

checking for ar... ar

checking for archiver @FILE support... @

checking for strip... strip

checking for ranlib... ranlib

checking command to parse /usr/bin/nm -B output from gcc object... ok

checking for sysroot... no

checking for a working dd... /usr/bin/dd

checking how to truncate binary pipes... /usr/bin/dd bs=4096 count=1

checking for mt... mt

checking if mt is a manifest tool... no

checking for stdio.h... yes

checking for stdlib.h... yes

checking for string.h... yes

checking for inttypes.h... yes

checking for stdint.h... yes

checking for strings.h... yes

checking for sys/stat.h... yes

checking for sys/types.h... yes

checking for unistd.h... yes

checking for sys/param.h... yes

checking for dlfcn.h... yes

checking for objdir... .libs

checking if gcc supports -fno-rtti -fno-exceptions... no

checking for gcc option to produce PIC... -fPIC -DPIC

checking if gcc PIC flag -fPIC -DPIC works... yes

checking if gcc static flag -static works... yes

checking if gcc supports -c -o file.o... yes

checking if gcc supports -c -o file.o... (cached) yes

checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes

checking whether -lc should be explicitly linked in... no

checking dynamic linker characteristics... GNU/Linux ld.so

checking how to hardcode library paths into programs... immediate

checking whether stripping libraries is possible... yes

checking if libtool supports shared libraries... yes

checking whether to build shared libraries... yes

checking whether to build static libraries... yes

checking for gcc... (cached) gcc

checking whether the compiler supports GNU C... (cached) yes

checking whether gcc accepts -g... (cached) yes

checking for gcc option to enable C11 features... (cached) none needed

checking whether gcc understands -c and -o together... (cached) yes

checking dependency style of gcc... (cached) gcc3

checking for numa_free in -lnuma... yes

checking for pthread_create in -lpthread... yes

checking for pkg-config... /usr/bin/pkg-config

checking pkg-config is at least version 0.9.0... yes

checking for check... yes

checking for ncursesw ncurses... yes

checking for fcntl.h... yes

checking for inttypes.h... (cached) yes

checking for limits.h... yes

checking for locale.h... yes

checking for stddef.h... yes

checking for stdint.h... (cached) yes

checking for stdlib.h... (cached) yes

checking for string.h... (cached) yes

checking for strings.h... (cached) yes

checking for sys/ioctl.h... yes

checking for sys/time.h... yes

checking for unistd.h... (cached) yes

checking for int64_t... yes

checking for pid_t... yes

checking for size_t... yes

checking for uint32_t... yes

checking for uint64_t... yes

checking for GNU libc compatible malloc... yes

checking for getpagesize... yes

checking for working mmap... yes

checking for GNU libc compatible realloc... yes

checking for working strtod... yes

checking for getpagesize... (cached) yes

checking for gettimeofday... yes

checking for memset... yes

checking for munmap... yes

checking for select... yes

checking for strcasecmp... yes

checking for strchr... yes

checking for strcspn... yes

checking for strstr... yes

checking for strtol... yes

checking for strtoull... yes

checking that generated files are newer than configure... done

configure: creating ./config.status

config.status: creating Makefile

config.status: creating config.h

config.status: executing depfiles commands

config.status: executing libtool commands

rm -f numatop

rm -rf .libs _libs

rm -rf common/.libs common/_libs

rm -rf common/os/.libs common/os/_libs

rm -rf powerpc/.libs powerpc/_libs

rm -rf x86/.libs x86/_libs

test -z "libnumatop.la" || rm -f libnumatop.la

rm -f ./so_locations

rm -f mgen

rm -f *.o

rm -f common/*.o

rm -f common/*.lo

rm -f common/os/*.o

rm -f common/os/*.lo

rm -f powerpc/*.o

rm -f powerpc/*.lo

rm -f test/mgen/*.o

rm -f test/mgen/powerpc/*.o

rm -f test/mgen/x86/*.o

rm -f x86/*.o

rm -f x86/*.lo

test -z "test/mgen.01.sh.log test/mgen.02.sh.log" || rm -f test/mgen.01.sh.log test/mgen.02.sh.log

test -z "test/mgen.01.sh.trs test/mgen.02.sh.trs" || rm -f test/mgen.01.sh.trs test/mgen.02.sh.trs

test -z "test-suite.log" || rm -f test-suite.log

rm -f *.lo

@.***:~/repos/numatop$ ./configure

checking for a BSD-compatible install... /usr/bin/install -c

checking whether build environment is sane... yes

checking for a race-free mkdir -p... /usr/bin/mkdir -p

checking for gawk... gawk

checking whether make sets $(MAKE)... yes

checking whether make supports nested variables... yes

checking build system type... x86_64-pc-linux-gnu

checking host system type... x86_64-pc-linux-gnu

checking how to print strings... printf

checking whether make supports the include directive... yes (GNU style)

checking for gcc... gcc

checking whether the C compiler works... yes

checking for C compiler default output file name... a.out

checking for suffix of executables...

checking whether we are cross compiling... no

checking for suffix of object files... o

checking whether the compiler supports GNU C... yes

checking whether gcc accepts -g... yes

checking for gcc option to enable C11 features... none needed

checking whether gcc understands -c and -o together... yes

checking dependency style of gcc... gcc3

checking for a sed that does not truncate output... /usr/bin/sed

checking for grep that handles long lines and -e... /usr/bin/grep

checking for egrep... /usr/bin/grep -E

checking for fgrep... /usr/bin/grep -F

checking for ld used by gcc... /usr/bin/ld

checking if the linker (/usr/bin/ld) is GNU ld... yes

checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B

checking the name lister (/usr/bin/nm -B) interface... BSD nm

checking whether ln -s works... yes

checking the maximum length of command line arguments... 1572864

checking how to convert x86_64-pc-linux-gnu file names to x86_64-pc-linux-gnu format... func_convert_file_noop

checking how to convert x86_64-pc-linux-gnu file names to toolchain format... func_convert_file_noop

checking for /usr/bin/ld option to reload object files... -r

checking for file... file

checking for objdump... objdump

checking how to recognize dependent libraries... pass_all

checking for dlltool... no

checking how to associate runtime and link libraries... printf %s\n

checking for ar... ar

checking for archiver @FILE support... @

checking for strip... strip

checking for ranlib... ranlib

checking command to parse /usr/bin/nm -B output from gcc object... ok

checking for sysroot... no

checking for a working dd... /usr/bin/dd

checking how to truncate binary pipes... /usr/bin/dd bs=4096 count=1

checking for mt... mt

checking if mt is a manifest tool... no

checking for stdio.h... yes

checking for stdlib.h... yes

checking for string.h... yes

checking for inttypes.h... yes

checking for stdint.h... yes

checking for strings.h... yes

checking for sys/stat.h... yes

checking for sys/types.h... yes

checking for unistd.h... yes

checking for sys/param.h... yes

checking for dlfcn.h... yes

checking for objdir... .libs

checking if gcc supports -fno-rtti -fno-exceptions... no

checking for gcc option to produce PIC... -fPIC -DPIC

checking if gcc PIC flag -fPIC -DPIC works... yes

checking if gcc static flag -static works... yes

checking if gcc supports -c -o file.o... yes

checking if gcc supports -c -o file.o... (cached) yes

checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes

checking whether -lc should be explicitly linked in... no

checking dynamic linker characteristics... GNU/Linux ld.so

checking how to hardcode library paths into programs... immediate

checking whether stripping libraries is possible... yes

checking if libtool supports shared libraries... yes

checking whether to build shared libraries... yes

checking whether to build static libraries... yes

checking for gcc... (cached) gcc

checking whether the compiler supports GNU C... (cached) yes

checking whether gcc accepts -g... (cached) yes

checking for gcc option to enable C11 features... (cached) none needed

checking whether gcc understands -c and -o together... (cached) yes

checking dependency style of gcc... (cached) gcc3

checking for numa_free in -lnuma... yes

checking for pthread_create in -lpthread... yes

checking for pkg-config... /usr/bin/pkg-config

checking pkg-config is at least version 0.9.0... yes

checking for check... yes

checking for ncursesw ncurses... yes

checking for fcntl.h... yes

checking for inttypes.h... (cached) yes

checking for limits.h... yes

checking for locale.h... yes

checking for stddef.h... yes

checking for stdint.h... (cached) yes

checking for stdlib.h... (cached) yes

checking for string.h... (cached) yes

checking for strings.h... (cached) yes

checking for sys/ioctl.h... yes

checking for sys/time.h... yes

checking for unistd.h... (cached) yes

checking for int64_t... yes

checking for pid_t... yes

checking for size_t... yes

checking for uint32_t... yes

checking for uint64_t... yes

checking for GNU libc compatible malloc... yes

checking for getpagesize... yes

checking for working mmap... yes

checking for GNU libc compatible realloc... yes

checking for working strtod... yes

checking for getpagesize... (cached) yes

checking for gettimeofday... yes

checking for memset... yes

checking for munmap... yes

checking for select... yes

checking for strcasecmp... yes

checking for strchr... yes

checking for strcspn... yes

checking for strstr... yes

checking for strtol... yes

checking for strtoull... yes

checking that generated files are newer than configure... done

configure: creating ./config.status

config.status: creating Makefile

config.status: creating config.h

config.status: config.h is unchanged

config.status: executing depfiles commands

config.status: executing libtool commands

@.***:~/repos/numatop$ make

make all-am

make[1]: Entering directory '/home/cking/repos/numatop'

gcc -DHAVE_CONFIG_H -I. -D_DEFAULT_SOURCE -D_XOPEN_SOURCE=600 -g -O2 -MT common/numatop-numatop.o -MD -MP -MF common/.deps/numatop-numatop.Tpo -c -o common/numatop-numatop.o test -f 'common/numatop.c' || echo './'common/numatop.c

mv -f common/.deps/numatop-numatop.Tpo common/.deps/numatop-numatop.Po

depbase=echo common/os/map.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||';\

/bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/map.lo -MD -MP -MF $depbase.Tpo -c -o common/os/map.lo common/os/map.c &&\

mv -f $depbase.Tpo $depbase.Plo

libtool: compile: gcc -DHAVE_CONFIG_H -I. -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/map.lo -MD -MP -MF common/os/.deps/map.Tpo -c common/os/map.c -fPIC -DPIC -o common/os/.libs/map.o

libtool: compile: gcc -DHAVE_CONFIG_H -I. -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/map.lo -MD -MP -MF common/os/.deps/map.Tpo -c common/os/map.c -o common/os/map.o >/dev/null 2>&1

depbase=echo common/os/node.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||';\

/bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/node.lo -MD -MP -MF $depbase.Tpo -c -o common/os/node.lo common/os/node.c &&\

mv -f $depbase.Tpo $depbase.Plo

libtool: compile: gcc -DHAVE_CONFIG_H -I. -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/node.lo -MD -MP -MF common/os/.deps/node.Tpo -c common/os/node.c -fPIC -DPIC -o common/os/.libs/node.o

libtool: compile: gcc -DHAVE_CONFIG_H -I. -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/node.lo -MD -MP -MF common/os/.deps/node.Tpo -c common/os/node.c -o common/os/node.o >/dev/null 2>&1

depbase=echo common/os/os_cmd.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||';\

/bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/os_cmd.lo -MD -MP -MF $depbase.Tpo -c -o common/os/os_cmd.lo common/os/os_cmd.c &&\

mv -f $depbase.Tpo $depbase.Plo

libtool: compile: gcc -DHAVE_CONFIG_H -I. -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/os_cmd.lo -MD -MP -MF common/os/.deps/os_cmd.Tpo -c common/os/os_cmd.c -fPIC -DPIC -o common/os/.libs/os_cmd.o

libtool: compile: gcc -DHAVE_CONFIG_H -I. -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/os_cmd.lo -MD -MP -MF common/os/.deps/os_cmd.Tpo -c common/os/os_cmd.c -o common/os/os_cmd.o >/dev/null 2>&1

depbase=echo common/os/os_page.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||';\

/bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/os_page.lo -MD -MP -MF $depbase.Tpo -c -o common/os/os_page.lo common/os/os_page.c &&\

mv -f $depbase.Tpo $depbase.Plo

libtool: compile: gcc -DHAVE_CONFIG_H -I. -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/os_page.lo -MD -MP -MF common/os/.deps/os_page.Tpo -c common/os/os_page.c -fPIC -DPIC -o common/os/.libs/os_page.o

libtool: compile: gcc -DHAVE_CONFIG_H -I. -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/os_page.lo -MD -MP -MF common/os/.deps/os_page.Tpo -c common/os/os_page.c -o common/os/os_page.o >/dev/null 2>&1

depbase=echo common/os/os_perf.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||';\

/bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/os_perf.lo -MD -MP -MF $depbase.Tpo -c -o common/os/os_perf.lo common/os/os_perf.c &&\

mv -f $depbase.Tpo $depbase.Plo

libtool: compile: gcc -DHAVE_CONFIG_H -I. -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/os_perf.lo -MD -MP -MF common/os/.deps/os_perf.Tpo -c common/os/os_perf.c -fPIC -DPIC -o common/os/.libs/os_perf.o

libtool: compile: gcc -DHAVE_CONFIG_H -I. -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/os_perf.lo -MD -MP -MF common/os/.deps/os_perf.Tpo -c common/os/os_perf.c -o common/os/os_perf.o >/dev/null 2>&1

depbase=echo common/os/os_util.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||';\

/bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/os_util.lo -MD -MP -MF $depbase.Tpo -c -o common/os/os_util.lo common/os/os_util.c &&\

mv -f $depbase.Tpo $depbase.Plo

libtool: compile: gcc -DHAVE_CONFIG_H -I. -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/os_util.lo -MD -MP -MF common/os/.deps/os_util.Tpo -c common/os/os_util.c -fPIC -DPIC -o common/os/.libs/os_util.o

libtool: compile: gcc -DHAVE_CONFIG_H -I. -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/os_util.lo -MD -MP -MF common/os/.deps/os_util.Tpo -c common/os/os_util.c -o common/os/os_util.o >/dev/null 2>&1

depbase=echo common/os/os_win.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||';\

/bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/os_win.lo -MD -MP -MF $depbase.Tpo -c -o common/os/os_win.lo common/os/os_win.c &&\

mv -f $depbase.Tpo $depbase.Plo

libtool: compile: gcc -DHAVE_CONFIG_H -I. -fPIC -O2 -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common -std=gnu99 -g -O2 -MT common/os/os_win.lo -MD -MP -MF common/os/.deps/os_win.Tpo -c common/os/os_win.c -fPIC -DPIC -o common/os/.libs/os_win.o

common/os/os_win.c: In function 'node_cpu_string':

common/os/os_win.c:177:45: error: 's2' undeclared (first use in this function); did you mean 's1'?

177 | int s2_len = sizeof(s2);

  |                                             ^~

  |                                             s1

common/os/os_win.c:177:45: note: each undeclared identifier is reported only once for each function it appears in

common/os/os_win.c:177:29: warning: variable 's2_len' set but not used [-Wunused-but-set-variable]

177 | int s2_len = sizeof(s2);

  |                             ^~~~~~

common/os/os_win.c:142:13: warning: unused variable 's1_len' [-Wunused-variable]

142 | int s1_len = size;

  |             ^~~~~~

make[1]: *** [Makefile:1015: common/os/os_win.lo] Error 1

make[1]: Leaving directory '/home/cking/repos/numatop'

make: *** [Makefile:694: all] Error 2

— Reply to this email directly, view it on GitHubhttps://github.com/intel/numatop/issues/78#issuecomment-2262354438, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATOPPO555J7YHFKVUU2DQCTZPHWTHAVCNFSM6AAAAABL2BATP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRSGM2TINBTHA. You are receiving this because you commented.Message ID: @.***>

ColinIanKing commented 3 months ago

Many thanks!