intel / opencl-clang

Other
136 stars 62 forks source link

v19.1.0 tag on ocl-open-180 branch #548

Closed anbe42 closed 1 month ago

anbe42 commented 1 month ago

The v19.1.0 tag has been placed on the ocl-open-180 branch, no ocl-open-190 branch has been created, yet.

This misses e.g. commit 98f76b9e848188dcfc8bf8ac3873dfef700688f9, but you'd probably want to update that to 19.1 first.

Looking at the diff from ocl-open-180 to main, I see in CMakeLists.txt some references to SPIRV_BASE_REVISION master and TARGET_BRANCH "ocl-open-110" in main and 81cf510c707c19ae5215763b824f80c25916fe5e seems to be missing in main, too.

wenju-he commented 1 month ago

Thank you @anbe42 for reporting this issue. I'm sorry for the mistake of v19.1.0 tag. I'm in the process of creating new ocl-open-190 branch.

https://github.com/intel/opencl-clang/commit/81cf510c707c19ae5215763b824f80c25916fe5e seems to be missing in main

This is fixed in https://github.com/intel/opencl-clang/pull/544

wenju-he commented 1 month ago

@anbe42 I have deleted the wrong v19.1.0 tag and release, and then created new v19.1.0 tag and release from ocl-open-190 branch