search

intel / openlldp

Other
54 stars 42 forks source link

Build flags changes #62

Closed apconole closed 3 years ago

apconole commented 4 years ago

@ffontaine and @kloczek - this isn't exactly what we've discussed, but I feel it's the best solution. Developers still get warnings on by default, and distros can enable warnings later. I agree with the original approach by @ffontaine after looking over hundreds of projects doing the same thing.

apconole commented 4 years ago

@sregister please review patch 1.

kloczek commented 4 years ago

As it is not possible to remove injecting compiler warning flags in autoconf IMO this is only movinf those injections from one place to another. Really .. instead polluting generic build process better would be move those flags to .travis.yml and/or bootstrap.sh.

As I wrote with that patch it woild be not possible to make test build with injected in $CFLAGS env variable exact dset of warning flags or just single warning flag.

apconole commented 4 years ago

Would adding a disable/enable for the warnings be okay?

apconole commented 4 years ago

I've changed patch 2/2 to include a flag "--{enable,disable}-warnings" which will turn off the warning flags. If this is acceptable, I will merge.

apconole commented 3 years ago

I am merging this. If something needs changing, let me know.