search

intel / openlldp

Other
54 stars 42 forks source link

tx: when operating in rx-only mode don't send a port shutdown pdu #69

Closed apconole closed 3 years ago

apconole commented 3 years ago

Currently, lldpad correctly transmits a shutdown pdu with ttl = 0s when transitioning from rxtx or txonly to rxonly. However, when we shutdown lldpad it will transmit a shutdown pdu even if the port is configured to rxonly mode. For some implementations of LLDP this can create a confusing state and lead to issues in the network. Correct this by only transmitting a shutdown PDU when going from any transmit mode to a receive only mode, and don't transmit PDUs on shutdown if the port agent isn't configured to transmit.

Reported-by: Matthew Whitehead mwhitehe@redhat.com Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1905210 Signed-off-by: Aaron Conole aconole@redhat.com

apconole commented 3 years ago

@gonzoleeman or @penguin359 can you take a look?

gonzoleeman commented 3 years ago

@gonzoleeman or @penguin359 can you take a look?

done

apconole commented 3 years ago

ugh... sorry I forgot to command amend and accidentally pushed this. I will submit a patch to fix the variable name.

ovsrobot commented 3 years ago

I pushed a fixed version of the patch, since I already made the error of pushing it up. Will backport to branch 1.1 as well.