search

intel / openlldp

Other
54 stars 42 forks source link

Static analysis scan fixes #79

Closed apconole closed 2 years ago

apconole commented 3 years ago

After a quick run through coverity and GCC's experimental scanner, a number of issues were flagged. While some were false positives, on some closer looks, it seems that some are real issues. None seem to be security issues, but all need to be addressed.

The bulk are errors during error processing. These should almost never occur, but we fix them here.

Signed-off-by: Aaron Conole aconole@redhat.com

apconole commented 3 years ago

@penguin359 please also have a look

praeluceo commented 3 years ago

Adding Shanon as he owns the validation process for this now. @srlawton, someone needs to build this pull request, and run it through some sanity tests, then we need to merge the PR. Send me an IM or an email if you need help getting that set up.

apconole commented 3 years ago

@hreinecke maybe you can provide a quick spot check of the patches? @sregister also? Reviewed-by / Acked-by ?

apconole commented 2 years ago

@srlawton any news?