search

intel / openlldp

Other
54 stars 42 forks source link

Add support for Additional Ethernet Capabilities TLV (Frame Preemption) #91

Closed vladimiroltean closed 1 year ago

vladimiroltean commented 1 year ago

The Linux kernel gained support for configuring the IEEE 802.3 MAC Merge layer via ethtool netlink: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=f3c6e128936e11e62d0af3c52f756194d79cf2e2 The intended usage for this feature is to advertise and negotiate the Frame Preemption feature with the link partner via the Additional Ethernet Capabilities (IEEE 802.3-2018 clause 79.3.7) TLV. This pull request adds support to lldpad and lldptool for this new TLV, and for talking to the kernel via the ethtool genetlink family. To that end, the lldpad program now links with libnl-genl-3.0 in addition to the libnl-3.0 it used so far.

apconole commented 1 year ago

Thanks for this - I didn't see a changelog entry for it. This is a user visible feature, please include a changelog update.

I didn't get a chance to test this code - on kernels which don't support the new API interface, I think it should work okay. I saw your upstream kernel patch series, and I hope to get some time this week to test.

vladimiroltean commented 1 year ago

Closing this PR and opening another one with the requested changes. I'd like to continue having the code in this form on an immutable branch.