intel / openvino-rs

Rust bindings for OpenVINO™
Apache License 2.0
80 stars 23 forks source link

Improve ElementType ergonomics #102

Closed pnehrer closed 3 months ago

pnehrer commented 3 months ago

Minor improvements to ElementType ergonomics:

If you accept, I have a follow-up PR that would change some of the u32 return values to ElementType in Node and Tensor, but this would be a breaking change.

abrown commented 3 months ago

@pnehrer, thanks again for the contribution! I'm going to merge #99 first since that was sitting in the queue and that might cause you a bit of rebasing headache — hopefully not too much. And feel free to replace those u32s with ElementType since we haven't yet published a version that contains these new 2.0 changes.

pnehrer commented 3 months ago

@abrown I resolved the merge conflict and this is now ready to go

pnehrer commented 3 months ago

Thank you again!