search

intel / ozone-wayland

Wayland implementation for Chromium Ozone classes
BSD 3-Clause "New" or "Revised" License
218 stars 82 forks source link

Fix the crash problem happening during the input method initialization #437

Closed joone closed 8 years ago

joone commented 8 years ago

When we set a instance of OzoneWebUI by calling LinuxUI::SetInstance in ChromeBrowserMainExtraPartsAura::PreEarlyInitialization, the instance should be initialized ahead by calling OzoneWebUI::Initialize(). However, we didn't. As a result, it caused the crash in InputMethodAuraLinux::InputMethodAuraLinux() because OzoneWebUI::Initialize() was not called ChromeBrowserMainExtraPartsAura::ToolkitInitialized due to the USE_X11 macro.

This CL allows OzoneWebUI::Initialize to be called in ChromeBrowserMainExtraPartsAura::ToolkitInitialized.

joone commented 8 years ago

Chromium now launches well.

joone commented 8 years ago

@kalyankondapally I've updated the comment.

kalyankondapally commented 8 years ago

@joone I meant your commit message, not the description here

joone commented 8 years ago

Updated.