search

intel / ozone-wayland

Wayland implementation for Chromium Ozone classes
BSD 3-Clause "New" or "Revised" License
218 stars 82 forks source link

OnKeyPress event not handled properly #453

Closed jbrianceau closed 7 years ago

jbrianceau commented 8 years ago

The "Gardening: Adapt to https://codereview.chromium.org/1236923003" commit (25315fc81890a54e49ea357b4ed0391eff868eb6) seems incomplete. According to what has been done in desktop_window_tree_host_x11.cc, we need to stop event propagation and we do not have to call SendEventToProcessor.

The following test page can be used to monitor OnKeyPress event: http://www.asquare.net/javascript/tests/KeyCode.html

jbrianceau commented 8 years ago

Fix proposal : https://github.com/jbrianceau/ozone-wayland/commit/ec897cd2e98722aa143166ff36c214214a238149

joone commented 8 years ago

@jbrianceau I will take a look at your patch. Thank you.

jbrianceau commented 8 years ago

@joone Thanks ! FYI, I just saw that this issue and https://github.com/01org/ozone-wayland/issues/419 are related.

jbrianceau commented 8 years ago

@joone: any update? Did you find time to take a look at my patch ?

jbrianceau commented 7 years ago

Change fixed following @joone comments (and rebased on top of master branch) available here : https://github.com/jbrianceau/ozone-wayland/commit/7cf1e955a64df6eac792800f0d29a71119227967

jbrianceau commented 7 years ago

Merged in master branch : https://github.com/01org/ozone-wayland/commit/607abb6913f761e3cb7dfccfd72e30173e4bc4ea Closing issue.