intel / p3-analysis-library

A library simplifying the collection and interpretation of P3 data.
https://intel.github.io/p3-analysis-library/
MIT License
7 stars 10 forks source link

Reconfiguring `black` workflow #20

Closed laserkelvin closed 1 year ago

laserkelvin commented 1 year ago

This PR reconfigures the black formatter part of the lint-format workflow by removing the autocommit action, and relying on the official psf version of the Github action.

The intention now is that the black workflow will simply check files within the p3 source for modifications that black would perform, as opposed to making and committing the changes.

Related issues

Fixes #19

Proposed changes

List out—with high level descriptions—what the commits within this PR do:

laserkelvin commented 1 year ago

I could test the workflow, too, by pushing some poorly formatted code to see if it triggers the action?

Pennycook commented 1 year ago

I could test the workflow, too, by pushing some poorly formatted code to see if it triggers the action?

Good idea. Let's do that.

laserkelvin commented 1 year ago

@Pennycook please take a look at the logs, but it seems to work - I'll revert and we can merge after that

Pennycook commented 1 year ago

@Pennycook please take a look at the logs, but it seems to work - I'll revert and we can merge after that

Looks perfect!

laserkelvin commented 1 year ago

I've reverted the fudge on _utils.py and the test passed. Merging!