[Feature request]: Python 3.8 EOL in 2024 - Githubissues

intel / p3-analysis-library

A library simplifying the collection and interpretation of P3 data.

https://intel.github.io/p3-analysis-library/

MIT License

7 stars 10 forks source link

[Feature request]: Python 3.8 EOL in 2024 #23

Closed laserkelvin closed 5 months ago

laserkelvin commented 9 months ago

Feature/behavior summary

According to PEP569, Python 3.8 will be dropped from support Oct-2024. Currently, it is the lowest version being supported by p3.

Request attributes

[ ] Would this be a refactor of existing code?
[X] Does this proposal require new package dependencies?
[X] Would this change break backwards compatibility?

Related issues

N/A

Solution description

We will need to:

Phase out Python 3.8 related features
Phase out Python 3.8 CI actions

Consider including Python 3.11/3.12 support; the latter was recently released.

Additional notes

No response

Pennycook commented 8 months ago

Would this change break backwards compatibility?

I just want to make sure we're on the same page here. I agree that this will break backwards compatibility in the sense that some installations of P3 Analysis Library will break until the Python package is updated, but am I right in thinking that this won't affect the public API?

If the public API doesn't change, we can get away with making this change right away.

EDIT: Wrong repository. 😆