intel / p3-analysis-library

A library simplifying the collection and interpretation of P3 data.
https://intel.github.io/p3-analysis-library/
MIT License
7 stars 10 forks source link

Validation does not check column types #43

Open Pennycook opened 4 months ago

Pennycook commented 4 months ago

Expected behavior

We should either:

Actual behavior

Loading data from an outside source (like JSON) that stores FOM information as strings can lead to strange results, because:

Steps to reproduce the problem

Use string representations of the FOM instead of numeric ones.

Specifications

Tested with the tip of main.

Pennycook commented 4 months ago

After some more investigation, it's now clear that we validate that columns are convertible to numeric values (with _require_numeric) but don't actually perform the conversion.