Open Pennycook opened 4 months ago
We should either:
fom
to_numeric
Loading data from an outside source (like JSON) that stores FOM information as strings can lead to strange results, because:
Use string representations of the FOM instead of numeric ones.
Tested with the tip of main.
main
After some more investigation, it's now clear that we validate that columns are convertible to numeric values (with _require_numeric) but don't actually perform the conversion.
_require_numeric
Expected behavior
We should either:
fom
) are actually numeric, and raise an exception if the condition does not hold; orto_numeric
) and raise an exception if the conversion fails.Actual behavior
Loading data from an outside source (like JSON) that stores FOM information as strings can lead to strange results, because:
Steps to reproduce the problem
Use string representations of the FOM instead of numeric ones.
Specifications
Tested with the tip of
main
.