search

intel / pailliercryptolib

Intel Paillier Cryptosystem Library is an open-source library which provides accelerated performance of a partial homomorphic encryption (HE), named Paillier cryptosystem, by utilizing Intel® IPP-Crypto on AVX512IFMA instructions. Intel Paillier Cryptosystem Library is certified for ISO compliance.
Apache License 2.0
70 stars 18 forks source link

Refactor pub priv key with smark pointers #38

Closed justalittlenoob closed 1 year ago

skmono commented 1 year ago

@justalittlenoob Let me try the serialization methods on this recent update

skmono commented 1 year ago

@justalittlenoob Made a few changes - reverted keypair member names. If we want to update the names, let's do it with a buffer version where we can display some warning messages that the names will be changed. Overall, it works perfectly fine. Will need to modify the Python bindings due to some changes we made. I'll verify it with IPCL-Python then let's merge it.

justalittlenoob commented 1 year ago

@justalittlenoob Made a few changes - reverted keypair member names. If we want to update the names, let's do it with a buffer version where we can display some warning messages that the names will be changed. Overall, it works perfectly fine. Will need to modify the Python bindings due to some changes we made. I'll verify it with IPCL-Python then let's merge it.

Sure. I agree. Very good advice:)

skmono commented 1 year ago

@justalittlenoob Added a few more updates - let me know what you think. Let's complete the PR after the CI/CD system is back online

justalittlenoob commented 1 year ago

@justalittlenoob Added a few more updates - let me know what you think. Let's complete the PR after the CI/CD system is back online

It looks good to me.