intel / parameter-framework

Plugin-based and rule-based framework for describing and controlling parameters

https://01.org/parameter-framework/

Other

60 stars 48 forks source link

Release tarball changes after realease #372

Open krocard opened 8 years ago

krocard commented 8 years ago

TLDR

Release tarball/zip content (thus hash) may change over time !

Context

All (sufficiently recent) release tarballs contain a .version file that is expected to contain the tag of the release. The tag name is added in the .version file during git export. The source controled .version contains the %D placeholder that is replaced with the commit ref names (not only tag, see git help gitattributes).

Problem:

If no patch as been merged after a release is taged, the .version contains the expected tag AND master
After at least one patch is merged, the .version contains only the expected tag

Thus release tarballs are not immutable with current release process.

krocard commented 8 years ago

This bug is very inconvenient for Yocto integration as reported by @mgaio (who find the bug). Yocto build system expects release tarball hash to be immutable.

dawagner commented 8 years ago

Proposals

Manually create release commits and manually update the version number. In order to reduce errors, we can write a release script.
Manually generate a tarball and attach it to the release.
Add a git note to commits corresponding to a release and use $Format: %N$ in the .version file. This implies a manual release step but has the advantage that, if we forget to do it, there is no problem doing it afterward.

krocard commented 8 years ago

:+1: for the git note solution.

shivank01 commented 7 years ago

I want to work on this bug. Is anyone already working on it???

dawagner commented 7 years ago

Hi, @shivank01. We are not currently working on it and you are welcome to!

shivank01 commented 7 years ago

I am a noobie in open source contribution and i am working on this bug but unable to install asio in ubuntu. Can you please tell me how to install it on ubuntu.

mgaio commented 7 years ago

Hi, deb package is libasio-dev