intel / perfmon

https://perfmon-events.intel.com
BSD 3-Clause "New" or "Revised" License
241 stars 39 forks source link

Resolve remaining spelling issues #100

Open edwarddavidbaker opened 1 year ago

edwarddavidbaker commented 1 year ago

Currently event lists, TMA spreadsheets, README markdown, and helper scripts contain a few spelling issues. The goal of this issue is to track notes and pull requests.

Related pull requests

Current spelling issues

Event files

Updated 2024-08-01 from 41823368dd03bd382d946de2675cde86bd1c79bd.

./IVT/events/ivytown_uncore.json: Thereofore ==> Therefore
./IVT/events/ivytown_uncore.json: Trackes ==> Tracks
./IVT/events/ivytown_uncore.json: banwidth ==> bandwidth
./IVT/events/ivytown_uncore.json: filted ==> filtered
./IVT/events/ivytown_uncore.json: occpancy ==> occupancy
./IVT/events/ivytown_uncore.json: occuapancy ==> occupancy
./IVT/events/ivytown_uncore.json: startved ==> starved, started
./JKT/events/Jaketown_core.json: pipeilne ==> pipeline
./JKT/events/Jaketown_core.json: reqisters ==> registers
./JKT/events/Jaketown_core.json: unchacheable ==> uncacheable
./JKT/events/Jaketown_uncore.json: Thereofore ==> Therefore
./JKT/events/Jaketown_uncore.json: banwidth ==> bandwidth
./JKT/events/Jaketown_uncore.json: filted ==> filtered
./JKT/events/Jaketown_uncore.json: occuapancy ==> occupancy
./NHM-EP/events/NehalemEP_core.json: Prediciton ==> Prediction
./NHM-EX/events/NehalemEX_core.json: Prediciton ==> Prediction
./SNB/events/sandybridge_core.json: pipeilne ==> pipeline
./SNB/events/sandybridge_core.json: reqisters ==> registers
./SNB/events/sandybridge_core.json: unchacheable ==> uncacheable
./SRF/metrics/perf/sierraforest_metrics_perf.json: contoller ==> controller
./SRF/metrics/sierraforest_metrics.json: contoller ==> controller
./WSM-EP-DP/events/WestmereEP-DP_core.json: Prediciton ==> Prediction
./WSM-EP-SP/events/WestmereEP-SP_core.json: Prediciton ==> Prediction

Scripting and Additional Documents

./scripts/create_perf_json.py: indentifier ==> identifier
./scripts/create_perf_json.py: seperator ==> separator

./TMA_Metrics-full.csv: Simultanous ==> Simultaneous

./README.md: RECIEVED ==> RECEIVED
edwarddavidbaker commented 1 year ago

Updating known event spelling issues based on tree at 9d62fc38.

./BDW-DE/events/broadwellde_uncore.json: servied ==> serviced
./BDX/events/broadwellx_uncore.json: servied ==> serviced
./CLX/events/cascadelakex_uncore_experimental.json: servied ==> serviced
./HSW/events/haswell_core.json: inflight ==> in-flight
./HSX/events/haswellx_core.json: inflight ==> in-flight
./HSX/events/haswellx_uncore.json: servied ==> serviced
./ICX/events/icelakex_uncore.json: servied ==> serviced
./ICX/events/icelakex_uncore_experimental.json: servied ==> serviced
./KNL/events/KnightsLanding_core.json: rehad ==> rehab
./KNM/events/KnightsLanding_core.json: rehad ==> rehab
./NHM-EP/events/NehalemEP_core.json: Prediciton ==> Prediction
./NHM-EX/events/NehalemEX_core.json: Prediciton ==> Prediction
./SKX/events/skylakex_uncore_experimental.json: servied ==> serviced
./SNR/events/snowridgex_uncore.json: servied ==> serviced
./SNR/events/snowridgex_uncore_experimental.json: servied ==> serviced
./WSM-EP-DP/events/WestmereEP-DP_core.json: Prediciton ==> Prediction
./WSM-EP-SP/events/WestmereEP-SP_core.json: Prediciton ==> Prediction
edwarddavidbaker commented 1 year ago

Updating known event spelling issues based on tree at 7d555c13.

./BDW-DE/events/broadwellde_uncore.json: servied ==> serviced
./BDX/events/broadwellx_uncore.json: servied ==> serviced
./CLX/events/cascadelakex_uncore_experimental.json: servied ==> serviced
./HSW/events/haswell_core.json: inflight ==> in-flight
./HSX/events/haswellx_core.json: inflight ==> in-flight
./HSX/events/haswellx_uncore.json: servied ==> serviced
./ICX/events/icelakex_uncore.json: servied ==> serviced
./ICX/events/icelakex_uncore_experimental.json: servied ==> serviced
./NHM-EP/events/NehalemEP_core.json: Prediciton ==> Prediction
./NHM-EX/events/NehalemEX_core.json: Prediciton ==> Prediction
./SKX/events/skylakex_uncore_experimental.json: servied ==> serviced
./SNR/events/snowridgex_uncore.json: servied ==> serviced
./SNR/events/snowridgex_uncore_experimental.json: servied ==> serviced
./WSM-EP-DP/events/WestmereEP-DP_core.json: Prediciton ==> Prediction
./WSM-EP-SP/events/WestmereEP-SP_core.json: Prediciton ==> Prediction
edwarddavidbaker commented 1 year ago

Removing TMA section in the summary. All issues were resolved in 20d83ce6e69.

edwarddavidbaker commented 1 year ago

Updating known event spelling issues based on Colin King's suggestions in https://github.com/intel/perfmon/pull/96/commits/37fcb3c3374216096557d71c5eac3d4adc90b65d.

./BDW-DE/events/broadwellde_uncore.json: filted ==> filtered
./BDW-DE/events/broadwellde_uncore.json: banwidth ==> bandwidth
./BDW-DE/events/broadwellde_uncore.json: occpancy ==> occupancy
./BDW-DE/events/broadwellde_uncore.json: banwidth ==> bandwidth
./BDW-DE/events/broadwellde_uncore.json: servied ==> serviced
./BDW-DE/events/broadwellde_uncore.json: startved ==> starved, started
./BDX/events/broadwellx_uncore.json: filted ==> filtered
./BDX/events/broadwellx_uncore.json: banwidth ==> bandwidth
./BDX/events/broadwellx_uncore.json: occpancy ==> occupancy
./BDX/events/broadwellx_uncore.json: banwidth ==> bandwidth
./BDX/events/broadwellx_uncore.json: servied ==> serviced
./BDX/events/broadwellx_uncore.json: startved ==> starved, started
./CLX/events/cascadelakex_core.json: michroarchtecture ==> microarchitecture
./CLX/events/cascadelakex_core.json: michroarchitecture ==> microarchitecture
./CLX/events/cascadelakex_uncore_experimental.json: servied ==> serviced
./CLX/events/cascadelakex_uncore_experimental.json: Trackes ==> Tracks
./EMR/events/emeraldrapids_uncore_experimental.json: Bouncable ==> Bounceable
./HSW/events/haswell_core.json: inflight ==> in-flight
./HSX/events/haswellx_core.json: inflight ==> in-flight
./HSX/events/haswellx_uncore.json: occpancy ==> occupancy
./HSX/events/haswellx_uncore.json: filted ==> filtered
./HSX/events/haswellx_uncore.json: banwidth ==> bandwidth
./HSX/events/haswellx_uncore.json: servied ==> serviced
./HSX/events/haswellx_uncore.json: Trackes ==> Tracks
./HSX/events/haswellx_uncore.json: startved ==> starved, started
./ICL/events/icelake_core.json: stravation ==> starvation
./ICL/events/icelake_core.json: microarchtecture ==> microarchitecture
./ICX/events/icelakex_core.json: stravation ==> starvation
./ICX/events/icelakex_core.json: microarchtecture ==> microarchitecture
./ICX/events/icelakex_uncore.json: servied ==> serviced
./ICX/events/icelakex_uncore_experimental.json: servied ==> serviced
./ICX/events/icelakex_uncore_experimental.json: Trackes ==> Tracks
./IVT/events/ivytown_uncore.json: Thereofore ==> Therefore
./IVT/events/ivytown_uncore.json: filted ==> filtered
./IVT/events/ivytown_uncore.json: banwidth ==> bandwidth
./IVT/events/ivytown_uncore.json: occpancy ==> occupancy
./IVT/events/ivytown_uncore.json: banwidth ==> bandwidth
./IVT/events/ivytown_uncore.json: startved ==> starved, started
./IVT/events/ivytown_uncore.json: occuapancy ==> occupancy
./IVT/events/ivytown_uncore.json: Trackes ==> Tracks
./JKT/events/Jaketown_core.json: reqisters ==> registers
./JKT/events/Jaketown_core.json: pipeilne ==> pipeline
./JKT/events/Jaketown_core.json: unchacheable ==> uncacheable
./JKT/events/Jaketown_uncore.json: Thereofore ==> Therefore
./JKT/events/Jaketown_uncore.json: filted ==> filtered
./JKT/events/Jaketown_uncore.json: banwidth ==> bandwidth
./JKT/events/Jaketown_uncore.json: occuapancy ==> occupancy
./NHM-EP/events/NehalemEP_core.json: Prediciton ==> Prediction
./NHM-EX/events/NehalemEX_core.json: Prediciton ==> Prediction
./RKL/events/rocketlake_core.json: stravation ==> starvation
./RKL/events/rocketlake_core.json: microarchtecture ==> microarchitecture
./SKL/events/skylake_core.json: michroarchitecture ==> microarchitecture
./SKX/events/skylakex_core.json: michroarchtecture ==> microarchitecture
./SKX/events/skylakex_core.json: michroarchitecture ==> microarchitecture
./SKX/events/skylakex_uncore.json: trafiic ==> traffic
./SKX/events/skylakex_uncore_experimental.json: servied ==> serviced
./SKX/events/skylakex_uncore_experimental.json: Trackes ==> Tracks
./SNB/events/sandybridge_core.json: reqisters ==> registers
./SNB/events/sandybridge_core.json: unchacheable ==> uncacheable
./SNB/events/sandybridge_core.json: pipeilne ==> pipeline
./SNR/events/snowridgex_uncore.json: servied ==> serviced
./SNR/events/snowridgex_uncore_experimental.json: servied ==> serviced
./SNR/events/snowridgex_uncore_experimental.json: Trackes ==> Tracks
./SPR/events/sapphirerapids_uncore_experimental.json: Bouncable ==> Bounceable
./TGL/events/tigerlake_core.json: stravation ==> starvation
./TGL/events/tigerlake_core.json: microarchtecture ==> microarchitecture
./WSM-EP-DP/events/WestmereEP-DP_core.json: Prediciton ==> Prediction
./WSM-EP-SP/events/WestmereEP-SP_core.json: Prediciton ==> Prediction
edwarddavidbaker commented 8 months ago

Updating based on 5774b4d06a087d3ab47eb4415b80624ba838069b.

./BDW-DE/events/broadwellde_uncore.json: filted ==> filtered
./BDW-DE/events/broadwellde_uncore.json: banwidth ==> bandwidth
./BDW-DE/events/broadwellde_uncore.json: occpancy ==> occupancy
./BDW-DE/events/broadwellde_uncore.json: banwidth ==> bandwidth
./BDW-DE/events/broadwellde_uncore.json: servied ==> serviced
./BDW-DE/events/broadwellde_uncore.json: startved ==> starved, started
./BDX/events/broadwellx_uncore.json: filted ==> filtered
./BDX/events/broadwellx_uncore.json: banwidth ==> bandwidth
./BDX/events/broadwellx_uncore.json: occpancy ==> occupancy
./BDX/events/broadwellx_uncore.json: banwidth ==> bandwidth
./BDX/events/broadwellx_uncore.json: servied ==> serviced
./BDX/events/broadwellx_uncore.json: startved ==> starved, started
./CLX/events/cascadelakex_core.json: michroarchtecture ==> microarchitecture
./CLX/events/cascadelakex_core.json: michroarchitecture ==> microarchitecture
./CLX/events/cascadelakex_uncore_experimental.json: servied ==> serviced
./CLX/events/cascadelakex_uncore_experimental.json: Trackes ==> Tracks
./HSW/events/haswell_core.json: inflight ==> in-flight
./HSX/events/haswellx_core.json: inflight ==> in-flight
./HSX/events/haswellx_uncore.json: occpancy ==> occupancy
./HSX/events/haswellx_uncore.json: filted ==> filtered
./HSX/events/haswellx_uncore.json: banwidth ==> bandwidth
./HSX/events/haswellx_uncore.json: servied ==> serviced
./HSX/events/haswellx_uncore.json: Trackes ==> Tracks
./HSX/events/haswellx_uncore.json: startved ==> starved, started
./IVT/events/ivytown_uncore.json: Thereofore ==> Therefore
./IVT/events/ivytown_uncore.json: filted ==> filtered
./IVT/events/ivytown_uncore.json: banwidth ==> bandwidth
./IVT/events/ivytown_uncore.json: occpancy ==> occupancy
./IVT/events/ivytown_uncore.json: banwidth ==> bandwidth
./IVT/events/ivytown_uncore.json: startved ==> starved, started
./IVT/events/ivytown_uncore.json: occuapancy ==> occupancy
./IVT/events/ivytown_uncore.json: Trackes ==> Tracks
./JKT/events/Jaketown_core.json: reqisters ==> registers
./JKT/events/Jaketown_core.json: pipeilne ==> pipeline
./JKT/events/Jaketown_core.json: unchacheable ==> uncacheable
./JKT/events/Jaketown_uncore.json: Thereofore ==> Therefore
./JKT/events/Jaketown_uncore.json: filted ==> filtered
./JKT/events/Jaketown_uncore.json: banwidth ==> bandwidth
./JKT/events/Jaketown_uncore.json: occuapancy ==> occupancy
./NHM-EP/events/NehalemEP_core.json: Prediciton ==> Prediction
./NHM-EX/events/NehalemEX_core.json: Prediciton ==> Prediction
./SKX/events/skylakex_core.json: michroarchtecture ==> microarchitecture
./SKX/events/skylakex_core.json: michroarchitecture ==> microarchitecture
./SKX/events/skylakex_uncore.json: trafiic ==> traffic
./SKX/events/skylakex_uncore_experimental.json: servied ==> serviced
./SKX/events/skylakex_uncore_experimental.json: Trackes ==> Tracks
./SNB/events/sandybridge_core.json: reqisters ==> registers
./SNB/events/sandybridge_core.json: unchacheable ==> uncacheable
./SNB/events/sandybridge_core.json: pipeilne ==> pipeline
./SNR/events/snowridgex_uncore.json: servied ==> serviced
./SNR/events/snowridgex_uncore_experimental.json: servied ==> serviced
./SNR/events/snowridgex_uncore_experimental.json: Trackes ==> Tracks
./TMA_Metrics-full.csv: Simultanous ==> Simultaneous
./WSM-EP-DP/events/WestmereEP-DP_core.json: Prediciton ==> Prediction
./WSM-EP-SP/events/WestmereEP-SP_core.json: Prediciton ==> Prediction
steguerrini commented 5 months ago

A minor error can be found in "For tool developers" in the spreadsheet:

E.g. if a Node := A / B with Metric Max of 1.0, the final value should be Node = max(1, A/B).

I think it should be

E.g. if a Node := A / B with Metric Max of 1.0, the final value should be Node = min(1, A/B).