search

intel / powertelemetry

Internal sources of Power Telemetry Library. Power Telemetry Library is a golang library that provides power-related CPU info.
Apache License 2.0
8 stars 2 forks source link

chore(deps): Upgrade gopsutil from v3 to v4 #7

Closed zmyzheng closed 11 hours ago

zmyzheng commented 1 month ago

This repo depends on gopsutil to retrieve system related metrics. However, the v3 version is no longer maintained, while the v4 version has new fixes, improves and better platform coverages.

zmyzheng commented 1 month ago

Hi @rdower, @ggalieroc , @p-zak ,could you please review this PR?

p-zak commented 3 weeks ago

@zmyzheng Thank you for the PR. Change needs to be tested, after that it will be reviewed.

zmyzheng commented 3 weeks ago

@zmyzheng Thank you for the PR. Change needs to be tested, after that it will be reviewed.

Any document on how to test it? Is there any auto testing (CI/CD) available in the build pipeline? I have manually tested the CPU functions using both v3 and v4 package and can confirm both have the same result.