search

intel / qatlib

Other
95 stars 34 forks source link

allow /etc/sysconfig/qat to have comment lines #58

Closed mrkz closed 4 months ago

mrkz commented 1 year ago

It's a common practice for configuration files in /etc/sysconfig to have comments in them, some examples on my current Fedora 38 machine are:

$ cat /etc/sysconfig/firewalld
# firewalld command line args
# possible values: --debug
FIREWALLD_ARGS=

and

$ cat /etc/sysconfig/anaconda
# This file has been generated by the Anaconda Installer 38.23.4

[General]
post_install_tools_disabled = 0

however, if I use comments on /etc/sysconfig/qat I get failures in configuring the device.

Please allow the /etc/sysconfig/qat file to be able to contain comments in them and ignore lines starting with #

jdschuet commented 12 months ago

Can you confirm whether this is observed with comments as shown above? (where comment starts at the beginning of line) Or is this observed with comments that occur after the contents of the line.. something like: POLICY = 1 # This is comment

mrkz commented 12 months ago

I had both comment patterns, but then I was contacted internally and got confirmation that comment-only lines are handled correctly, so I'd say the culprit may be the later

POLICY=1 # comment
jdschuet commented 12 months ago

Thank-you for confirming. I've recreated the issue and also see that it affects comments at the end of line. I've raised internal ticket to track this through resolution. Thank-you for raising this issue.

jdschuet commented 4 months ago

Update with planned resolution. Comments are supported at beginning of line, but not at end of line.